From: "Andreas Färber" <afaerber@suse.de>
To: Alex Horn <alex.horn@cs.ox.ac.uk>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.
Date: Wed, 05 Dec 2012 13:47:02 +0100 [thread overview]
Message-ID: <50BF4246.1060408@suse.de> (raw)
In-Reply-To: <1354710846-10687-1-git-send-email-alex.horn@cs.ox.ac.uk>
Am 05.12.2012 13:34, schrieb Alex Horn:
> * Define enum for TMP105 registers
> * Move tmp105_set() from I2C to TMP105 header
> * Document units and range of temperature as preconditions
>
> Signed-off-by: Alex Horn <alex.horn@cs.ox.ac.uk>
Looks great, thanks!
Reviewed-by: Andreas Färber <afaerber@suse.de>
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-05 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 12:34 [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor Alex Horn
2012-12-05 12:47 ` Andreas Färber [this message]
2012-12-23 21:26 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 19:23 Alex Horn
2012-12-04 21:50 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF4246.1060408@suse.de \
--to=afaerber@suse.de \
--cc=alex.horn@cs.ox.ac.uk \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).