From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgOCi-0002Zx-7P for qemu-devel@nongnu.org; Wed, 05 Dec 2012 18:16:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgOCf-0000et-Me for qemu-devel@nongnu.org; Wed, 05 Dec 2012 18:16:36 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:32931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgOCf-0000em-Fj for qemu-devel@nongnu.org; Wed, 05 Dec 2012 18:16:33 -0500 Received: by mail-ob0-f173.google.com with SMTP id xn12so5390074obc.4 for ; Wed, 05 Dec 2012 15:16:32 -0800 (PST) Sender: Richard Henderson Message-ID: <50BFD5CE.9040109@twiddle.net> Date: Wed, 05 Dec 2012 17:16:30 -0600 From: Richard Henderson MIME-Version: 1.0 References: <1354663750-2163-1-git-send-email-petar.jovanovic@rt-rk.com> <50BF69EA.8080306@twiddle.net> <50BF6D9D.2030901@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: rth7680@gmail.com, Petar Jovanovic , qemu-devel@nongnu.org, blauwirbel@gmail.com, petarj@mips.com, afaerber@suse.de, aurelien@aurel32.net On 2012-12-05 10:38, Peter Maydell wrote: > I don't think we should block this patch on that general > cleanup, though. All the sign extensions in target-mips/translate.c > are done in the double-shift way, so this is consistent with > the existing code. Fair enough. The original can have my Reviewed-by: Richard Henderson r~