From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgRq2-0006sx-Oz for qemu-devel@nongnu.org; Wed, 05 Dec 2012 22:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgRq1-00045t-89 for qemu-devel@nongnu.org; Wed, 05 Dec 2012 22:09:26 -0500 Received: from mail4.hitachi.co.jp ([133.145.228.5]:58345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgRq0-00042m-Oc for qemu-devel@nongnu.org; Wed, 05 Dec 2012 22:09:25 -0500 Message-ID: <50C00C92.3000104@hitachi.com> Date: Thu, 06 Dec 2012 12:10:10 +0900 From: Tomoki Sekiyama MIME-Version: 1.0 References: <20121130133349.32478.47493.stgit@melchior2.sdl.hitachi.co.jp> <20121130133357.32478.6554.stgit@melchior2.sdl.hitachi.co.jp> <20121204145144.3f2837e7@doriath.home> <50BF08A4.4030903@hitachi.com> <20121205094934.4db6917b@doriath.home> In-Reply-To: <20121205094934.4db6917b@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lcapitulino@redhat.com Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 2012/12/05 20:49, Luiz Capitulino wrote: > On Wed, 05 Dec 2012 17:41:08 +0900 > Tomoki Sekiyama wrote: > >> On 2012/12/05 1:51, Luiz Capitulino wrote: >>> On Fri, 30 Nov 2012 22:33:57 +0900 >>> Tomoki Sekiyama wrote: >>> >>>> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >>>> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >>>> - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot >>>> >>>> Signed-off-by: Tomoki Sekiyama >>>> --- >>>> docs/qemu-guest-agent/fsfreeze-hook | 33 ++++++++++++ >>>> .../fsfreeze-hook.d.sample/mysql-flush.sh | 55 ++++++++++++++++++++ >>>> 2 files changed, 88 insertions(+) >>>> create mode 100755 docs/qemu-guest-agent/fsfreeze-hook >>>> create mode 100755 docs/qemu-guest-agent/fsfreeze-hook.d.sample/mysql-flush.sh >>>> >>>> diff --git a/docs/qemu-guest-agent/fsfreeze-hook b/docs/qemu-guest-agent/fsfreeze-hook >>>> new file mode 100755 >>>> index 0000000..ed7d86d >>>> --- /dev/null >>>> +++ b/docs/qemu-guest-agent/fsfreeze-hook >>>> @@ -0,0 +1,33 @@ >>>> +#!/bin/sh >>>> + >>>> +# This script is executed when a guest agent receives fsfreeze-freeze and >>>> +# fsfreeze-thaw command, if it is specified in --fsfreeze-hook (-F) >>>> +# option of qemu-ga or placed in default path (/etc/qemu/fsfreeze-hook). >>>> +# When the agent receives fsfreeze-freeze request, this script is issued with >>>> +# "freeze" argument before the filesystem is freezed. And for fsfreeze-thaw >>>> +# request, it is issued with "thaw" argument after filesystem is thawed. >>>> + >>>> +LOGFILE=/var/log/qga-fsfreeze-hook.log >>>> +FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d >>> >>> The script you introduce is called fsfreeze-hook.d.sample. If it's expected >>> that people really use these two scripts (vs. doc purposes only) I suggest >>> the following: >>> >>> 1. Move these files to scripts/ >>> 2. Drop the .sample suffix >> >> It is good for "fsfreeze-hook". But as for "mysql-flush.sh", users may >> need to configure authentication etc. if their environments are with >> non-default setup (by edditing either the script or ~/.my.cnf file). >> >> So, I'd like to (1)move these files to scripts/, but (2)reamin .sample >> suffix to indicate that users may need to modify the script. >> How do you think? > > You could add the '.sample' suffix to the mysql script and add that > suffix to is_ignored_file(). > Okey, I will try this in the next version. (It seems Makefile also needs a patch to treat directry named "*.d".) Thanks, -- Tomoki Sekiyama Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory