From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49023)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgbyL-0002eb-AB
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 08:58:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgbyJ-0001nG-V7
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 08:58:41 -0500
Received: from greensocs.com ([87.106.252.221]:48044
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TgbyJ-0001nB-Or
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 08:58:39 -0500
Message-ID: <50C0A489.1030106@greensocs.com>
Date: Thu, 06 Dec 2012 14:58:33 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1354631742-4693-1-git-send-email-fred.konrad@greensocs.com>
	<1354631742-4693-7-git-send-email-fred.konrad@greensocs.com>
	<CAFEAcA88zwZc8X0pmsa0DvC3=2o3ZpKUt=r3r8221SixX=pirg@mail.gmail.com>
	<50BF82ED.4070205@suse.de> <50C063A5.6050101@greensocs.com>
	<50C06B0C.7040901@suse.de>
	<CAFEAcA80t1fZPovFyW2mh6fVWS2LurWXBa7dyz=b=O+TkNZo4g@mail.gmail.com>
In-Reply-To: <CAFEAcA80t1fZPovFyW2mh6fVWS2LurWXBa7dyz=b=O+TkNZo4g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor
	virtio-blk.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

On 06/12/2012 11:13, Peter Maydell wrote:
> On 6 December 2012 09:53, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 06.12.2012 10:21, schrieb KONRAD Fr=C3=A9d=C3=A9ric:
>>> I agree with that, but, there is an issue :
>>> The refactored VirtIOBlk is a device and seems to work, but the devic=
e
>>> which use this VirtIOBlock
>>> (eg virtio-blk-pci) are just allocating a structure ( in
>>> virtio_common_init ).
>>>
>>> That's why this patch is breaking virtio-blk-pci.
>> Don't understand that part due to lack of virtio knowledge...
>> Patch 5/6 introduces VirtIODevice as sitting on TYPE_VIRTIO_BUS. So wi=
th
>> this patch VirtIOBlk is moving to that new bus and virtio-blk-pci shou=
ld
>> only be necessary as a command line option alias for backwards
>> compatibility, no?
> It can't just be a command line alias, or we will break migration.
> It has to be a simple device that composes together the virtio-pci
> and virtio-blk devices, plus legacy support for properties and
> migration state, I think.
>
> -- PMM
Can we do virtio-blk refactoring and virtio-blk-pci at the same time for =
not
breaking anything ?

Or do you have a better idea ?

Fred