From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tgdbq-0004j5-SW for qemu-devel@nongnu.org; Thu, 06 Dec 2012 10:43:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tgdbp-0006KQ-1I for qemu-devel@nongnu.org; Thu, 06 Dec 2012 10:43:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36133 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tgdbo-0006Hd-O9 for qemu-devel@nongnu.org; Thu, 06 Dec 2012 10:43:32 -0500 Message-ID: <50C0BCF8.60504@suse.de> Date: Thu, 06 Dec 2012 16:42:48 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1351652644-18687-1-git-send-email-afaerber@suse.de> <1351652644-18687-4-git-send-email-afaerber@suse.de> <20121206153725.GH4986@otherpad.lan.raisama.net> In-Reply-To: <20121206153725.GH4986@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/7] target-alpha: Add support for -cpu ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, rth@twiddle.net Am 06.12.2012 16:37, schrieb Eduardo Habkost: > On Wed, Oct 31, 2012 at 04:04:00AM +0100, Andreas F=E4rber wrote: >> Implement alphabetical listing of CPU subclasses. >> >> Signed-off-by: Andreas F=E4rber >> --- >> target-alpha/cpu.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> target-alpha/cpu.h | 4 +++- >> 2 Dateien ge=E4ndert, 44 Zeilen hinzugef=FCgt(+), 1 Zeile entfernt(-) >> >> diff --git a/target-alpha/cpu.c b/target-alpha/cpu.c >> index e1a5739..ab25c44 100644 >> --- a/target-alpha/cpu.c >> +++ b/target-alpha/cpu.c >> @@ -23,6 +23,47 @@ >> #include "qemu-common.h" >> =20 >> =20 >> +typedef struct AlphaCPUListState { >> + fprintf_function cpu_fprintf; >> + FILE *file; >> +} AlphaCPUListState; >> + >> +/* Sort alphabetically by type name. */ >> +static gint alpha_cpu_list_compare(gconstpointer a, gconstpointer b) >> +{ >> + ObjectClass *class_a =3D (ObjectClass *)a; >> + ObjectClass *class_b =3D (ObjectClass *)b; >> + const char *name_a, *name_b; >> + >> + name_a =3D object_class_get_name(class_a); >> + name_b =3D object_class_get_name(class_b); >> + return strcmp(name_a, name_b); >> +} >> + >> +static void alpha_cpu_list_entry(gpointer data, gpointer user_data) >> +{ >> + ObjectClass *oc =3D data; >> + AlphaCPUListState *s =3D user_data; >> + >> + (*s->cpu_fprintf)(s->file, " %s\n", >> + object_class_get_name(oc)); >> +} >> + >> +void alpha_cpu_list(FILE *f, fprintf_function cpu_fprintf) >> +{ >> + AlphaCPUListState s =3D { >> + .file =3D f, >> + .cpu_fprintf =3D cpu_fprintf, >> + }; >> + GSList *list; >> + >> + list =3D object_class_get_list(TYPE_ALPHA_CPU, false); >> + list =3D g_slist_sort(list, alpha_cpu_list_compare); >> + (*cpu_fprintf)(f, "Available CPUs:\n"); >> + g_slist_foreach(list, alpha_cpu_list_entry, &s); >> + g_slist_free(list); >> +} >=20 > target-arm has very similar code. Isn't it better to first write a > common reusable function to list CPU models using the list of > subclasses, instead of adding very similar functions to all > architectures? Most ordering functions vary slightly (target-arm for "any"). It would be possible to generalize the struct and provide a wrapper with type and callback arguments, but then again some functions add a header line like here, some don't, and some even hardcode some options like "host". For the targets that already had -cpu ? support before QOM I tried to keep output identical apart from possibly the order. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg