[Qemu-devel] [PULL] target-s390x reorg, v4

[Qemu-devel] [PULL] target-s390x reorg, v4

[Richard Henderson]

Rebased to commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e pull from

  git://repo.or.cz/qemu/rth.git s390-reorg

The only substantive change from the last ping is to put my name in
the maintainer slot for the code.


r~


Richard Henderson (152):
  tcg: Add TCGV_IS_UNUSED_*
  target-s390: Disassemble more z10 and z196 opcodes
  target-s390: Fix disassembly of cpsdr
  target-s390: Fix gdbstub
  target-s390: Add missing temp_free in gen_op_calc_cc
  target-s390: Use TCG registers for FPR
  target-s390: Register helpers
  target-s390: Fix SACF exit
  target-s390: Fix BCR
  target-s390: Tidy unconditional BRCL
  target-s390: Fix PSW_MASK handling
  target-s390: Add format based disassassmbly infrastructure
  target-s390: Split out disas_jcc
  target-s390: Reorg exception handling
  target-s390: Convert ADD HALFWORD
  target-s390: Implement SUBTRACT HALFWORD
  target-s390: Implement ADD LOGICAL WITH SIGNED IMMEDIATE
  target-s390: Convert MULTIPLY HALFWORD, SINGLE
  target-s390: Convert 32-bit MULTIPLY, MULTIPLY LOGICAL
  target-s390: Convert 64-bit MULTIPLY LOGICAL
  target-s390: Convert AND, OR, XOR
  target-s390: Convert COMPARE, COMPARE LOGICAL
  target-s390: Convert LOAD, LOAD LOGICAL
  target-s390: Convert LOAD ADDRESS
  target-s390: Convert LOAD (LOGICAL) BYTE, CHARACTER, HALFWORD
  target-s390: Convert LOAD AND TEST
  target-s390: Convert LOAD LOGICAL IMMEDIATE
  target-s390: Convert LOAD COMPLIMENT, POSITIVE, NEGATIVE
  target-s390: Convert AND, OR, XOR, INSERT IMMEDIATE
  target-s390: Convert STORE
  target-s390: Convert ADD LOGICAL CARRY and SUBTRACT LOGICAL BORROW
  target-s390: Convert BRANCH AND SAVE
  target-s390: Convert BRANCH ON CONDITION
  target-s390: Convert BRANCH ON COUNT
  target-s390: Convert DIVIDE
  target-s390: Send signals for divide
  target-s390: Convert TEST UNDER MASK
  target-s390: Convert SET ADDRESSING MODE
  target-s390: Convert SUPERVISOR CALL
  target-s390: Convert MOVE LONG
  target-s390: Convert FP LOAD
  target-s390: Convert INSERT CHARACTER
  target-s390: Cleanup cc computation helpers
  target-s390: Convert INSERT CHARACTERS UNDER MASK
  target-s390: Convert EXECUTE
  target-s390: Convert FP STORE
  target-s390: Convert CONVERT TO DECIMAL
  target-s390: Convert SET SYSTEM MASK
  target-s390: Convert LOAD PSW
  target-s390: Convert DIAGNOSE
  target-s390: Convert SHIFT, ROTATE SINGLE
  target-s390: Convert SHIFT DOUBLE
  target-s390: Convert LOAD, STORE MULTIPLE
  target-s390: Convert MOVE
  target-s390: Convert NI, XI, OI
  target-s390: Convert STNSM, STOSM
  target-s390: Convert LAM, STAM
  target-s390: Convert CLCLE, MVCLE
  target-s390: Convert MVC
  target-s390: Convert NC, XC, OC, TR, UNPK
  target-s390: Convert CLC
  target-s390: Convert MVCP, MVCS
  target-s390: Convert LRA
  target-s390: Convert SIGP
  target-s390: Convert EFPC, STFPC
  target-s390: Convert LCTL, STCTL
  target-s390: Convert COMPARE AND SWAP
  target-s390: Convert CLM
  target-s390: Convert STCM
  target-s390: Convert TPROT
  target-s390: Convert LOAD CONTROL, part 2
  target-s390: Convert LOAD REVERSED
  target-s390: Convert STORE REVERSED
  target-s390: Convert LLGT
  target-s390: Convert FP ADD, COMPARE, LOAD TEST/ROUND/LENGTHENED
  target-s390: Convert FP SUBTRACT
  target-s390: Convert FP DIVIDE
  target-s390: Convert FP MULTIPLY
  target-s390: Convert MULTIPLY AND ADD, SUBTRACT
  target-s390: Convert TEST DATA CLASS
  target-s390: Convert FP LOAD COMPLIMENT, NEGATIVE, POSITIVE
  target-s390: Convert FP SQUARE ROOT
  target-s390: Convert LOAD ZERO
  target-s390: Convert CONVERT TO FIXED
  target-s390: Convert CONVERT FROM FIXED
  target-s390: Convert FLOGR
  target-s390: Convert LFPC, SFPC
  target-s390: Convert IPM
  target-s390: Convert CKSM
  target-s390: Convert EAR, SAR
  target-s390: Convert MVPG
  target-s390: Convert CLST, MVST
  target-s390: Convert SRST
  target-s390: Convert STIDP
  target-s390: Convert SCK
  target-s390: Convert STCK
  target-s390: Convert SCKC, STCKC
  target-s390: Convert SPT, STPT
  target-s390: Convert SPKA
  target-s390: Convert PTLB
  target-s390: Convert SPX, STPX
  target-s390: Convert STAP
  target-s390: Convert IPTE
  target-s390: Convert ISKE
  target-s390: Convert SSKE
  target-s390: Convert RRBE
  target-s390: Convert subchannel instructions
  target-s390: Convert STURA
  target-s390: Convert CSP
  target-s390: Convert STCKE
  target-s390: Convert SACF
  target-s390: Convert STSI
  target-s390: Convert STFL
  target-s390: Convert LPSWE
  target-s390: Convert SERVC
  target-s390: Delete dead code from old translator
  target-s390: Implement BRANCH ON INDEX
  target-s390: Tidy s->op_cc handling
  target-s390: Implement COMPARE AND BRANCH
  target-s390: Implement RISBG
  target-s390: Implement LDGR, LGDR
  target-s390: Implement R[NOX]SBG
  target-s390: Implement PREFETCH
  target-s390: Implement COMPARE RELATIVE LONG
  target-s390: Implement COMPARE AND TRAP
  target-s390: Implement LOAD ON CONDITION
  target-s390: Implement STORE ON CONDITION
  target-s390: Implement CONVERT TO LOGICAL
  target-s390: Implement CONVERT FROM LOGICAL
  target-s390: Implement POPCNT
  target-s390: Implement CPSDR
  target-s390: Check insn operand specifications
  target-s390: Implement LCDFR
  softfloat: Fix uint64_to_float64
  softfloat: Implement uint64_to_float128
  target-s390: Use uint64_to_float128
  target-s390: Implement SET ROUNDING MODE
  target-s390: Implement LOAD/SET FP AND SIGNAL
  target-s390: Fix cpu_clone_regs
  target-s390: Optimize XC
  target-s390: Optmize emitting discards
  target-s390: Tidy comparisons
  target-s390: Optimize ADDU/SUBU CC testing
  target-s390: Optimize ADDC/SUBB
  target-s390: Optimize get_address
  target-s390: Perform COMPARE AND SWAP inline
  target-s390: Use TCG_CALL_NO_WG for memory helpers
  target-s390: Use TCG_CALL_NO_WG for floating-point helpers
  target-s390: Use TCG_CALL_NO_WG for integer helpers
  target-s390: Use TCG_CALL_NO_WG for misc helpers
  target-s390: Use noreturn for exception and load_psw
  target-s390: Claim maintainership

 MAINTAINERS                  |    1 +
 fpu/softfloat.c              |   15 +-
 fpu/softfloat.h              |    1 +
 gdbstub.c                    |   78 +-
 linux-user/main.c            |  140 +-
 linux-user/s390x/syscall.h   |    2 +-
 s390-dis.c                   |  173 +-
 target-s390x/cc_helper.c     |  335 +-
 target-s390x/cpu.h           |  167 +-
 target-s390x/fpu_helper.c    |  960 ++---
 target-s390x/helper.c        |   67 +-
 target-s390x/helper.h        |  220 +-
 target-s390x/insn-data.def   |  813 ++++
 target-s390x/insn-format.def |   55 +
 target-s390x/int_helper.c    |  176 +-
 target-s390x/mem_helper.c    |  359 +-
 target-s390x/misc_helper.c   |   97 +-
 target-s390x/translate.c     | 8685 ++++++++++++++++++++----------------------
 tcg/tcg.h                    |    3 +
 19 files changed, 6368 insertions(+), 5979 deletions(-)
 create mode 100644 target-s390x/insn-data.def
 create mode 100644 target-s390x/insn-format.def

-- 
1.7.11.7

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Alexander Graf]

On 06.12.2012, at 00:11, Richard Henderson wrote:

> Rebased to commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e pull from
> 
>  git://repo.or.cz/qemu/rth.git s390-reorg
> 
> The only substantive change from the last ping is to put my name in
> the maintainer slot for the code.

Acked-by: Alexander Graf <agraf@suse.de>

I would like to make sure that someone knowledgable in the areas acks the tcg and softfloat patches. Peter, you had been involved in this quite a bit, right?

We can pull this either through my tree or Aurelien/Blue can accept this pull request directly. I'm fine either way, as long as you consider the MAINTAINER entry to be targeting s390x TCG :).


Alex

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Andreas Färber]

Am 06.12.2012 01:09, schrieb Alexander Graf:
> 
> On 06.12.2012, at 00:11, Richard Henderson wrote:
> 
>> Rebased to commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e pull from
>>
>>  git://repo.or.cz/qemu/rth.git s390-reorg
>>
>> The only substantive change from the last ping is to put my name in
>> the maintainer slot for the code.
> 
> Acked-by: Alexander Graf <agraf@suse.de>
> 
> I would like to make sure that someone knowledgable in the areas acks the tcg and softfloat patches. Peter, you had been involved in this quite a bit, right?
> 
> We can pull this either through my tree or Aurelien/Blue can accept this pull request directly. I'm fine either way, as long as you consider the MAINTAINER entry to be targeting s390x TCG :).

It is under the heading "Guest CPU cores (TCG)", but the pattern
F: target-s390/
applies to all files, including kvm.c, unless you add
X: target-s390/kvm.c

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Richard Henderson]

On 2012-12-05 18:09, Alexander Graf wrote:
> I would like to make sure that someone knowledgable in the areas acks the tcg and softfloat patches. Peter, you had been involved in this quite a bit, right?

We've already got an Reviewed-by for the tcg patch from Aurelien.

Shall I pull these pieces out for separate application, leaving
the s390 pull to pure s390 patches?


r~

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Peter Maydell]

On 6 December 2012 00:09, Alexander Graf <agraf@suse.de> wrote:
> I would like to make sure that someone knowledgable in the areas acks
> the tcg and softfloat patches. Peter, you had been involved in this
> quite a bit, right?

I commented on the two softfloat patches in an earlier round:
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg05166.html
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg05167.html
but the current git tree has the original code still.
(style issues rather than actual bugs)

-- PMM

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Alexander Graf]

On 07.12.2012, at 19:18, Richard Henderson wrote:

> On 2012-12-05 18:09, Alexander Graf wrote:
>> I would like to make sure that someone knowledgable in the areas acks the tcg and softfloat patches. Peter, you had been involved in this quite a bit, right?
> 
> We've already got an Reviewed-by for the tcg patch from Aurelien.
> 
> Shall I pull these pieces out for separate application, leaving
> the s390 pull to pure s390 patches?

Could you please send another pull request without the softfloat bits, then rework those and get Peter's ack on them? :)


Alex

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Richard Henderson]

On 12/17/2012 09:01 AM, Alexander Graf wrote:
> Could you please send another pull request without the softfloat bits, then rework those and get Peter's ack on them? :)

I've got reviews on all the prerequisites, but they aren't merged yet.

http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg02008.html
http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg01408.html
http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg01409.html

I'll rebase the s390 stuff when those are in.


r~

Re: [Qemu-devel] [PULL] target-s390x reorg, v4

[Alexander Graf]

On 17.12.2012, at 19:19, Richard Henderson wrote:

> On 12/17/2012 09:01 AM, Alexander Graf wrote:
>> Could you please send another pull request without the softfloat bits, then rework those and get Peter's ack on them? :)
> 
> I've got reviews on all the prerequisites, but they aren't merged yet.
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg02008.html
> http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg01408.html
> http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg01409.html
> 
> I'll rebase the s390 stuff when those are in.

Ah, sorry. Must have missed those :)


Thanks for keeping up your awesome work!

Alex