From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time
Date: Fri, 07 Dec 2012 19:18:37 +0100 [thread overview]
Message-ID: <50C232FD.9030306@suse.de> (raw)
In-Reply-To: <20121207175702.GI4986@otherpad.lan.raisama.net>
Am 07.12.2012 18:57, schrieb Eduardo Habkost:
> On Thu, Dec 06, 2012 at 10:06:57AM +0100, Andreas Färber wrote:
> [...]
>> ---
>> target-i386/cpu.c | 3 ---
>> 1 Datei geändert, 3 Zeilen entfernt(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index a631ae9..f56aa0d 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1381,9 +1381,6 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features)
>> if (kvm_check_features_against_host(x86_cpu_def) && enforce_cpuid)
>> goto error;
>> }
>> - if (x86_cpu_def->cpuid_7_0_ebx_features && x86_cpu_def->level < 7) {
>> - x86_cpu_def->level = 7;
>> - }
>> return 0;
>>
>> error:
>
> NACK. A patch chunk is missing. I will resend the fixed version, just in
> case.
Uh, mismerge... thanks for noticing! Fixed.
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-07 18:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:06 [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06 Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 01/13] user: Move *-user/qemu-types.h to main directory Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 02/13] user: Rename qemu-types.h to qemu-user-types.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 03/13] ui/vnc-palette.c: Include headers it needs Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 04/13] qapi/qmp-registry.c: " Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 05/13] qga/channel-posix.c: " Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 06/13] qlist.h: Do not include qemu-common.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 07/13] Create qemu-types.h for struct typedefs Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 08/13] sysemu.h: Include qemu-types.h instead of qemu-common.h Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 09/13] qdev: qdev_create(): use error_report() instead of hw_error() Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 10/13] target-i386/cpu.c: Coding style fixes Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 11/13] target-i386: Separate feature string parsing from CPU model lookup Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 12/13] target-i386: Use define for cpuid vendor string size Andreas Färber
2012-12-06 9:06 ` [Qemu-devel] [PATCH 13/13] target-i386: Postpone cpuid_level update to realize time Andreas Färber
2012-12-07 17:57 ` Eduardo Habkost
2012-12-07 18:18 ` Andreas Färber [this message]
2012-12-07 18:00 ` [Qemu-devel] [PATCH] " Eduardo Habkost
2012-12-07 18:28 ` Andreas Färber
2012-12-07 18:21 ` [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06 Andreas Färber
2012-12-10 16:57 ` Anthony Liguori
2012-12-10 17:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C232FD.9030306@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).