From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2aD-0004De-QP for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:23:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Th2aC-0002yo-ES for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:23:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2aC-0002yk-5k for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:23:32 -0500 Message-ID: <50C233FE.5020904@redhat.com> Date: Fri, 07 Dec 2012 11:22:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp> <20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp> <20121207115516.5e363012@doriath.home> In-Reply-To: <20121207115516.5e363012@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7D6F429518CB27D27B38A67E" Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Tomoki Sekiyama , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7D6F429518CB27D27B38A67E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/07/2012 06:55 AM, Luiz Capitulino wrote: > On Fri, 07 Dec 2012 17:39:32 +0900 > Tomoki Sekiyama wrote: >=20 >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >> - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snaps= hot >> >> Signed-off-by: Tomoki Sekiyama >> --- >> .gitignore | 1=20 >> Makefile | 2 - >> scripts/qemu-guest-agent/fsfreeze-hook | 33 +++++++++++= + >> .../fsfreeze-hook.d/mysql-flush.sh.sample | 55 +++++++++++= +++++++++ >> 4 files changed, 90 insertions(+), 1 deletion(-) >> create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook >> create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flu= sh.sh.sample >> >> diff --git a/.gitignore b/.gitignore >> index bd6ba1c..286822d 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -93,3 +93,4 @@ cscope.* >> tags >> TAGS >> *~ >> +!scripts/qemu-guest-agent/fsfreeze-hook.d >=20 > Why? Do we expect to have *~ files in there? What does your question have to do with the patch, which isn't even touching the pre-existing *~ line? >=20 >> diff --git a/Makefile b/Makefile >> index 9ecbcbb..466dcd7 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -248,7 +248,7 @@ clean: >> # avoid old build problems by removing potentially incorrect old file= s >> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm= =2Eh gen-op-arm.h >> rm -f qemu-options.def >> - find . -name '*.[od]' -exec rm -f {} + >> + find . -name '*.[od]' -type f -exec rm -f {} + >=20 > What does this change have to do with this patch? Because this patch introduces a directory scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample that belongs to the repo and therefore must not be cleaned. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7D6F429518CB27D27B38A67E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQwjP/AAoJEKeha0olJ0NqhmEH/25ighkNWKnDA2GnmVW1/YdK xXfSnPXKmK61JX1ZnRBXZWdP79RjFRoNMvkDyFnmN+Op3AsLXmCuz5EK7cr87HYX umrORz4Ur6MM+jMtEM3kKFaz+x75AriNjBr6baOuigPCmbwYVMbFzh4oREiF0MQE aPMj01QEoy7xGH01wd8SnsGOwpmJnPKOoTzhbLhoXuFEfeqAblfw/jx1lL1ewS1J eNMRaSLRqLvz7C9NbW/8egNQ4NnSjdDL8SdrYYUodM9S4MZZuMrZtndpXyw0AvA5 B4ETsvU+Q915eqE8fix5tgi35Jw2s3fTj2BcwF2XjhGYUMdQ8raC2b2ICeaAvaI= =237c -----END PGP SIGNATURE----- --------------enig7D6F429518CB27D27B38A67E--