From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2oE-0004ZI-PE for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:38:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Th2oC-00072B-EK for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:38:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th2oC-000725-6R for qemu-devel@nongnu.org; Fri, 07 Dec 2012 13:38:00 -0500 Message-ID: <50C23778.3020507@redhat.com> Date: Fri, 07 Dec 2012 11:37:44 -0700 From: Eric Blake MIME-Version: 1.0 References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp> <20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp> <20121207115516.5e363012@doriath.home> <50C233FE.5020904@redhat.com> <20121207163113.2f238c8f@doriath.home> In-Reply-To: <20121207163113.2f238c8f@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigFECED407E701D8E22004B88F" Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Tomoki Sekiyama , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFECED407E701D8E22004B88F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/07/2012 11:31 AM, Luiz Capitulino wrote: >>>> +++ b/.gitignore >>>> @@ -93,3 +93,4 @@ cscope.* >>>> tags >>>> TAGS >>>> *~ >>>> +!scripts/qemu-guest-agent/fsfreeze-hook.d >>> >>> Why? Do we expect to have *~ files in there? >> >> What does your question have to do with the patch, which isn't even >> touching the pre-existing *~ line? >=20 > As far I could understand the ! prefix in gitignore documention, it's > changing the *~ meaning for the fsfreeze-hoo.d directory, and I wanted > to understand why. >=20 No, it is changing a much earlier line: *.d to say that this _particular_ .d is allowed to be committed. It has nothing to do with *~. Still, I have to wonder if we really want to store these files in a .d in the repository itself, or if we should store them under some other file name and only at 'make install' time insert them into a .d at the install destination. It would clean up this confusion about the =2Egitignore as well as the change to the 'find' command during 'make cle= an'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigFECED407E701D8E22004B88F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQwjd4AAoJEKeha0olJ0Nq5K4H/AsM6AcIdU2IDEana2ManGcJ 2uRNqagZMwYnbqmrktSZRwemQlKneCZP/avHHipML+v5oay2fusrd13peo/qiC+D i4kRrvCXuM64rOfdEnQtzzArgRlwbgks3bucdNRZgE/gDTyDKJXhYnumqOahILAh N3YVMljIRRNDK0sDVRuk6f025/mKmOqoDMDEDpk4aGRCwbZEmTNbO2HQdBtIMEwB nifitU4wVJwOf3aPVC2UGSbogs0ge3jjyXxq3I3o5aTmvu/lJL63eZzmk+VMpH3B l6G5VofhrYReR0VY4K0E+0i5Yt2QWchF6D22TZ/tRBVIZ7nHPDaqBWZ15ddkYYM= =/Vym -----END PGP SIGNATURE----- --------------enigFECED407E701D8E22004B88F--