From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th39r-0004mf-Nk for qemu-devel@nongnu.org; Fri, 07 Dec 2012 14:00:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Th39m-0004nU-80 for qemu-devel@nongnu.org; Fri, 07 Dec 2012 14:00:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40102 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Th39m-0004lo-2Q for qemu-devel@nongnu.org; Fri, 07 Dec 2012 14:00:18 -0500 Message-ID: <50C23CB9.2020508@suse.de> Date: Fri, 07 Dec 2012 20:00:09 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354828325-16568-1-git-send-email-imammedo@redhat.com> <1354828325-16568-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1354828325-16568-3-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mdroth@linux.vnet.ibm.com Am 06.12.2012 22:12, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > v2: > - replace visit_type_freq() with visit_type_unit_suffixed_int() > in x86_cpuid_set_tsc_freq() > --- > target-i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index c6c2ca0..b7f0aba 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1195,7 +1195,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, V= isitor *v, void *opaque, > const int64_t max =3D INT64_MAX; > int64_t value; > =20 > - visit_type_int(v, &value, name, errp); > + visit_type_unit_suffixed_int(v, &value, name, 1000, errp); > if (error_is_set(errp)) { > return; > } This trivial usage is fine obviously. But since this series set out to make things more generic I am missing at least one use case for 1024. Does nothing like that exist in qdev-properties.c or so already? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg