From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThwlK-0000OM-Cf for qemu-devel@nongnu.org; Mon, 10 Dec 2012 01:22:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThwlJ-0003t1-0V for qemu-devel@nongnu.org; Mon, 10 Dec 2012 01:22:46 -0500 Received: from mail4.hitachi.co.jp ([133.145.228.5]:50137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThwlI-0003st-HT for qemu-devel@nongnu.org; Mon, 10 Dec 2012 01:22:44 -0500 Message-ID: <50C57FE0.3020502@hitachi.com> Date: Mon, 10 Dec 2012 15:23:28 +0900 From: Tomoki Sekiyama MIME-Version: 1.0 References: <20121207083922.10624.97583.stgit@melchior2.sdl.hitachi.co.jp> <20121207083932.10624.8173.stgit@melchior2.sdl.hitachi.co.jp> <20121207115516.5e363012@doriath.home> <50C233FE.5020904@redhat.com> <20121207163113.2f238c8f@doriath.home> <50C23778.3020507@redhat.com> <20121207165748.0bf3b55e@doriath.home> In-Reply-To: <20121207165748.0bf3b55e@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lcapitulino@redhat.com Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Hi, sorry for my late reply. On 2012/12/08 3:57, Luiz Capitulino wrote: > On Fri, 07 Dec 2012 11:37:44 -0700 > Eric Blake wrote: > >> On 12/07/2012 11:31 AM, Luiz Capitulino wrote: >>>>>> +++ b/.gitignore >>>>>> @@ -93,3 +93,4 @@ cscope.* >>>>>> tags >>>>>> TAGS >>>>>> *~ >>>>>> +!scripts/qemu-guest-agent/fsfreeze-hook.d >>>>> >>>>> Why? Do we expect to have *~ files in there? >>>> >>>> What does your question have to do with the patch, which isn't even >>>> touching the pre-existing *~ line? >>> >>> As far I could understand the ! prefix in gitignore documention, it's >>> changing the *~ meaning for the fsfreeze-hoo.d directory, and I wanted >>> to understand why. >>> >> >> No, it is changing a much earlier line: >> >> *.d >> >> to say that this _particular_ .d is allowed to be committed. It has >> nothing to do with *~. Yes, it's for adding fsfreeze-hook.d into the repo. > Ah, now it makes a lot of sense, thanks Eric. > > It would be nice to move it right below *.d, to avoid stupid comments :) And OK, I will move this there. >> Still, I have to wonder if we really want to store these files in a .d >> in the repository itself, or if we should store them under some other >> file name and only at 'make install' time insert them into a .d at the >> install destination. It would clean up this confusion about the >> .gitignore as well as the change to the 'find' command during 'make clean'. > > Well, now that I understand it both ways are fine with me (ie. what you > suggest and what's been implemented in this patch). Then I'd like to keep current implementation. Thanks, -- Tomoki Sekiyama Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory