From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti2ap-0005oX-76 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 07:36:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti2aj-0003K2-0p for qemu-devel@nongnu.org; Mon, 10 Dec 2012 07:36:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti2ai-0003Jp-PV for qemu-devel@nongnu.org; Mon, 10 Dec 2012 07:36:12 -0500 Message-ID: <50C5D735.8070902@redhat.com> Date: Mon, 10 Dec 2012 13:36:05 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1354925118-23061-1-git-send-email-keith.busch@intel.com> <50C37FF9.9090904@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Keith Busch Cc: Keith Busch , qemu-devel@nongnu.org, "Michael S. Tsirkin" , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Hannes Reinecke Hi Keith, Am 08.12.2012 20:20, schrieb Keith Busch: >> IIUC from the website above, NVMe is to be used with SSDs? It would be >> good to add to the commit message how to actually use the device >> command-line-wise beyond the obvious -device nvme: I did not spot on >> brief sight where you expose a bus to add drives (nor a special IF_* >> interface type to assign to a drive), so others might wonder as well. > > Actually the nvme device _is_ the SSD. The emulated controller here > creates files to use for its backing storage so you don't add > additional drives, if that makes sense. I think the device would be much more useful if you could make it use the qemu block layer instead of implementing your own functions for only raw images and only with a given magic file name. Kevin