qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Elta Era <elta.era@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.
Date: Mon, 10 Dec 2012 09:41:08 -0800	[thread overview]
Message-ID: <50C61EB4.6010708@twiddle.net> (raw)
In-Reply-To: <CAEomy4Q6NFL5z-fKJPDWB5SszrxdhJw-tKt3or1Cou1eXHCQbg@mail.gmail.com>

On 12/10/2012 12:37 AM, Elta Era wrote:
>                  tcg_gen_movi_tl(cpu_gpr[ret], \
> -                                (target_long)((int32_t)imm << 16 | \
> +                                (target_long)(int32_t)((int32_t)imm << 16 | \
>                                  (uint32_t)(uint16_t)imm));

This can alternately be fixed by removing an unnecessary cast:

-  (target_long)((int32_t)imm << 16 | (uint32_t)(uint16_t)imm)
+  (target_long)((int32_t)imm << 16 | (uint16_t)imm)



r~

  parent reply	other threads:[~2012-12-10 17:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  8:37 [Qemu-devel] Some patch about mips, gen_HILO bug fix Elta Era
2012-12-10  9:22 ` 陳韋任 (Wei-Ren Chen)
2012-12-10 17:41 ` Richard Henderson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-12-10 16:07 Jovanovic, Petar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C61EB4.6010708@twiddle.net \
    --to=rth@twiddle.net \
    --cc=elta.era@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).