From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Ti7Lu-0007id-Rz
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 12:41:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Ti7Lr-0006Am-QK
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 12:41:14 -0500
Received: from mail-ie0-f180.google.com ([209.85.223.180]:57078)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Ti7Lr-0006Ac-M0
	for qemu-devel@nongnu.org; Mon, 10 Dec 2012 12:41:11 -0500
Received: by mail-ie0-f180.google.com with SMTP id c10so8910480ieb.25
	for <qemu-devel@nongnu.org>; Mon, 10 Dec 2012 09:41:11 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50C61EB4.6010708@twiddle.net>
Date: Mon, 10 Dec 2012 09:41:08 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <CAEomy4Q6NFL5z-fKJPDWB5SszrxdhJw-tKt3or1Cou1eXHCQbg@mail.gmail.com>
In-Reply-To: <CAEomy4Q6NFL5z-fKJPDWB5SszrxdhJw-tKt3or1Cou1eXHCQbg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Elta Era <elta.era@gmail.com>
Cc: qemu-devel@nongnu.org

On 12/10/2012 12:37 AM, Elta Era wrote:
>                  tcg_gen_movi_tl(cpu_gpr[ret], \
> -                                (target_long)((int32_t)imm << 16 | \
> +                                (target_long)(int32_t)((int32_t)imm << 16 | \
>                                  (uint32_t)(uint16_t)imm));

This can alternately be fixed by removing an unnecessary cast:

-  (target_long)((int32_t)imm << 16 | (uint32_t)(uint16_t)imm)
+  (target_long)((int32_t)imm << 16 | (uint16_t)imm)



r~