From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiLQb-0001wX-Vy for qemu-devel@nongnu.org; Tue, 11 Dec 2012 03:43:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiLQV-0002ny-WD for qemu-devel@nongnu.org; Tue, 11 Dec 2012 03:43:01 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:45542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiLQV-0002nA-Da for qemu-devel@nongnu.org; Tue, 11 Dec 2012 03:42:55 -0500 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Dec 2012 14:12:36 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 134CD3940054 for ; Tue, 11 Dec 2012 14:12:49 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBB8gl3c28246212 for ; Tue, 11 Dec 2012 14:12:47 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBB8glrf027410 for ; Tue, 11 Dec 2012 19:42:48 +1100 Message-ID: <50C6F1AE.8030000@linux.vnet.ibm.com> Date: Tue, 11 Dec 2012 16:41:18 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1354645978-17362-1-git-send-email-ehabkost@redhat.com> <1355082353-322-1-git-send-email-afaerber@suse.de> <1355082353-322-4-git-send-email-afaerber@suse.de> <20121210180920.GQ4255@otherpad.lan.raisama.net> <50C66C57.9010800@suse.de> <20121210235344.GU4255@otherpad.lan.raisama.net> In-Reply-To: <20121210235344.GU4255@otherpad.lan.raisama.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-cpu 3/4] Really finally kill cpudef config section support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Anthony Liguori , Riku Voipio , qemu-devel@nongnu.org, blauwirbel@gmail.com, imammedo@redhat.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= 于 2012-12-11 7:53, Eduardo Habkost 写道: > On Tue, Dec 11, 2012 at 12:12:23AM +0100, Andreas Färber wrote: >> Am 10.12.2012 19:09, schrieb Eduardo Habkost: >>> On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote: >>>> Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef >>>> config section support) removed the cpudef parsing support but left >>>> cpudef_* hooks behind. Remove those. >>> >>> The cpudef_* functions have nothing to do with the cpudef config section >>> since QEMU 1.2, it is just about initializing CPU-definition-related >>> data structures, so the patch subject is a bit misleading. >> >> My memory tells me they were specifically added for the config file >> support... git-blame proves me wrong and shows they were added by Johan >> Cooper and refactored by Blue, explaining his sudden cpudef patch >> involvement. Sorry. >> >> Do you have a proposal for a better text? My reasoning is we should >> clean up before we forget about it and things stay behind. > > Something like "kill the cpudef_setup() hook that we don't need anymore > [because only x86 uses it, and we can simply use class_init to > initialize data structures]" sounds good enough to me. > Hi, Eduardo I think we need uninstall rules which should delete the def files, otherwise we met error: qemu-system-x86_64:/usr/local/etc/qemu/target-x86_64.conf:3: There is no option group 'cpudef' -- Best Regards Wenchao Xia