From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiLwY-0005vx-Mk
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:16:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiLwS-0003TD-42
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:16:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12449)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiLwR-0003T4-RQ
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 04:15:56 -0500
Message-ID: <50C6F9C7.5010608@redhat.com>
Date: Tue, 11 Dec 2012 10:15:51 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20121208114601.24292.65396.malonedeb@wampee.canonical.com>
	<20121210155458.27947.19873.malone@gac.canonical.com>
	<20121211085711.GC23720@stefanha-thinkpad.muc.redhat.com>
In-Reply-To: <20121211085711.GC23720@stefanha-thinkpad.muc.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png
 produces garbled output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Bug 1087974 <1087974@bugs.launchpad.net>, qemu-devel@nongnu.org

On 12/11/12 09:57, Stefan Hajnoczi wrote:
> On Mon, Dec 10, 2012 at 03:54:58PM -0000, Tim Hardeck wrote:
>> 47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit
>> commit 47683d669f993308c2b84bed4ce64aafb5d7ced4
>> Author: Gerd Hoffmann <kraxel@redhat.com>
>> Date:   Thu Oct 11 12:04:33 2012 +0200
>>
>>     pixman/vnc: remove rgb_prepare_row* functions
>>
>>     Let pixman do it instead.
>>
>>     Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>
>> :040000 040000 653d58e66bf3a2d8240b2f9176979c44ccd720e1
>> 6b6e367a8522cb58b42ad8f204387a354d3b3d00 M  ui
>>
>>
>> Just reverting this particular commit isn't enough thou but it is connected.
> 
> This suggests the conversion to pixman has introduced the bug.

Quite possible.  I've tested tight via 'vncviewer
PreferredEncoding=Tight', but that doesn't force png, so there is a
chance for issues I havn't seen.

> Tim: can you provide steps to reproduce the bug?

That will certainly help fixing.

Also: How garbled?  Totally messed up?  Just colors wrong?  Any other
visible pattern?

cheers,
  Gerd