From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiNL1-0001db-QK for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:45:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiNKt-0004EP-Vl for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:45:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiNDJ-0002WG-8I for qemu-devel@nongnu.org; Tue, 11 Dec 2012 05:37:25 -0500 Message-ID: <50C70CDC.7040200@redhat.com> Date: Tue, 11 Dec 2012 11:37:16 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1355140582-5354-1-git-send-email-chouteau@adacore.com> <20121211092151.GB30567@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20121211092151.GB30567@stefanha-thinkpad.muc.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, Fabien Chouteau Am 11.12.2012 10:21, schrieb Stefan Hajnoczi: > On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: >> An error has occurred if the return value is invalid_set_file_pointer >> and getlasterror doesn't return no_error. >> >> Signed-off-by: Fabien Chouteau >> --- >> block/raw-win32.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) > > The fprintf() is kind of iffy but we only return -EIO so I guess it > helps to print the full error. > > Acked-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin