From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiRp8-0005gM-0u
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:32:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiRp3-0003Yk-Lu
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:32:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52153)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TiRp3-0003Yd-ER
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:32:41 -0500
Message-ID: <50C74825.4010800@redhat.com>
Date: Tue, 11 Dec 2012 15:50:13 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20121208114601.24292.65396.malonedeb@wampee.canonical.com>
	<20121211100937.24493.23255.malone@gac.canonical.com>
In-Reply-To: <20121211100937.24493.23255.malone@gac.canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png
 produces garbled output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bug 1087974 <1087974@bugs.launchpad.net>
Cc: Tim Hardeck <thardeck@suse.de>, qemu-devel@nongnu.org

On 12/11/12 11:09, Tim Hardeck wrote:
> * make sure that qemu is compiled with --enable-vnc-png
> 
> * git clone git://github.com/kanaka/noVNC
> * edit include/rfb.js at line 50 and comment out or remove all encodings above "['TIGHT_PNG',        -260 ],"
> * open vnc.html in Firefox or Chrome
> 
> *apply either my patch to QEMU https://lists.nongnu.org/archive/html
> /qemu-devel/2012-12/msg00869.html or use Websockify
> https://github.com/kanaka/websockify to get Websocket support.
> 
> * in case of my patch run QEMU with  `-vnc :0,websocket` and connect
> with noVNC to port 5700.
> 
> * in case of Websockify run QEMU with `./websockify.py 5900 -- qemu-
> system-x86_64 -vnc :0` and connect to port 5900

Hmm, doesn't reproduce here (using websockify proxy).

--- a/include/rfb.js
+++ b/include/rfb.js
@@ -48,8 +48,8 @@ var that           = {},  // Public API methods

     // In preference order
     encodings      = [
-        ['COPYRECT',         0x01 ],
-        ['TIGHT',            0x07 ],
+//        ['COPYRECT',         0x01 ],
+//        ['TIGHT',            0x07 ],
         ['TIGHT_PNG',        -260 ],
         ['HEXTILE',          0x05 ],
         ['RRE',              0x02 ],


cheers,
  Gerd