From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TiS8f-0004KQ-Un
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:53:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TiS8e-0001AQ-Tp
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:52:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TiS8e-0001AM-Mc
	for qemu-devel@nongnu.org; Tue, 11 Dec 2012 10:52:56 -0500
Message-ID: <50C756CF.8020602@redhat.com>
Date: Tue, 11 Dec 2012 16:52:47 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1354776447-12041-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1354776447-12041-10-git-send-email-wdongxu@linux.vnet.ibm.com>
In-Reply-To: <1354776447-12041-10-git-send-email-wdongxu@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V7 09/10] Use QemuOpts support in block
	layer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Am 06.12.2012 07:47, schrieb Dong Xu Wang:
> This patch will use QemuOpts related functions in block layer, add
> a member bdrv_create_options to BlockDriver struct, it will return
> a QemuOptsList pointer, which includes the image format's create
> options.
> 
> And create options's primary consumer is block creating related functions,
> so modify them together.
> 
> This patch also define a macro called STRINGIZER, it is used to convert
> number to string.
> 
> v6->v7:
> 1) use osdep.h:stringify(), not redefining new macro.
> 2) preserve TODO comment.
> 3) fix typo: BLOCK_OPT_ENCRYPT->BLOCK_OPT_STATIC.
> 4) initialize disk_type even when opts is NULL.
> 
> v5->v6:
> 1) judge if opts == NULL in block layer create functions.
> 2) use bdrv_create_file(filename, NULL) in qcow_create and cow_create funtion.
> 3) made more readable while using qemu_opt_get_number.
> 
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>

This doesn't apply any more and needs a rebase.

Kevin