Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

On 11/28/2012 01:04 PM, mdroth wrote:
> On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote:
>> This series revamps qemu-ga error messages by:
>>
>>  - Propagating errors down to functions that generate errors
>>  - Fixing UndefinedErrors
>>  - Getting rid of sprint() + error_set()
>>  - Other small fixes
> 
> Hi Luiz,
> 
> Patches look good other than a few comments on usage of possibly-unset errno.
> 
> CC'ing Eric as a heads up, but based on previous comments (libvirt
> always using 'desc' field over 'class' field and reporting it directly
> to users) I don't think it should cause any compatibility issues on that
> end.

And finally replying.  You are correct that libvirt favors the contents
of 'desc' and only if that is missing falls back to 'class' when passing
an error message through to the user.  I didn't spot any issues with the
changes in this series, although I admit my testing was rather light.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]