From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TilFW-0000rz-KA for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:17:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TilFK-0005NU-OU for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:17:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TilFK-0005NA-GG for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:17:06 -0500 Message-ID: <50C7D7DC.8020602@redhat.com> Date: Tue, 11 Dec 2012 18:03:24 -0700 From: Eric Blake MIME-Version: 1.0 References: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com> <20121128200431.GM8690@vm> In-Reply-To: <20121128200431.GM8690@vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig458859785520171F4BFBA355" Subject: Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig458859785520171F4BFBA355 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/28/2012 01:04 PM, mdroth wrote: > On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: >> This series revamps qemu-ga error messages by: >> >> - Propagating errors down to functions that generate errors >> - Fixing UndefinedErrors >> - Getting rid of sprint() + error_set() >> - Other small fixes >=20 > Hi Luiz, >=20 > Patches look good other than a few comments on usage of possibly-unset = errno. >=20 > CC'ing Eric as a heads up, but based on previous comments (libvirt > always using 'desc' field over 'class' field and reporting it directly > to users) I don't think it should cause any compatibility issues on tha= t > end. And finally replying. You are correct that libvirt favors the contents of 'desc' and only if that is missing falls back to 'class' when passing an error message through to the user. I didn't spot any issues with the changes in this series, although I admit my testing was rather light. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig458859785520171F4BFBA355 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQx9fcAAoJEKeha0olJ0NqZBMH/0RgLlKUUOioQuuw93lwsgG1 RFoBHzVqq/SCHpVA9OASetDNcVR2sJNZ47ySeoM18RUr4SR6Xrj+xMyQyX87OiHz 7nQTzSf2kaHP0LVsMOoBuRYA96+Y6pp/b2w+/mnFETraomyUIXttujA3ayxjm0hh ZU/yCCXEswUHjU1uL3LzLaMvMekUPFgnkRQF2DjwCFVrUzU+NTfceL/8H1a2mgFy 94bobUkw2XdA56wlQ89l/u8wFmgIEFX2h+JwBX/8/CypKzeMB9MXBOPYCaJtY0oV 93KbZ7VNd9YpBzdV8/Ybzb6giqyCYQ1r1+jU5/JX4w8qTagC7WqZypdBti+2Dl8= =aMWe -----END PGP SIGNATURE----- --------------enig458859785520171F4BFBA355--