From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>,
"asias@redhat.com" <asias@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi
Date: Wed, 12 Dec 2012 12:39:11 +0100 [thread overview]
Message-ID: <50C86CDF.8010403@siemens.com> (raw)
In-Reply-To: <20121212104821.GA6324@redhat.com>
On 2012-12-12 11:48, Michael S. Tsirkin wrote:
> Deleting a GSI isn't necessary: it is enough
> to stop using it. Delay flush until an entry is used.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> kvm-all.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 3bc3347..fb3180d 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -991,8 +991,6 @@ void kvm_irqchip_release_virq(KVMState *s, int virq)
> }
> }
> clear_gsi(s, virq);
> -
> - kvm_irqchip_commit_routes(s);
> }
>
> static unsigned int kvm_hash_msi(uint32_t data)
>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-12-12 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 10:48 [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi Michael S. Tsirkin
2012-12-12 11:39 ` Jan Kiszka [this message]
2012-12-13 4:55 ` Asias He
2012-12-13 15:34 ` Jan Kiszka
2012-12-14 1:00 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C86CDF.8010403@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=asias@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).