From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tilku-0000vz-4u for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:49:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tikeh-00039N-5W for qemu-devel@nongnu.org; Wed, 12 Dec 2012 06:40:19 -0500 Received: from goliath.siemens.de ([192.35.17.28]:30957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tikeg-00039H-P8 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 06:39:15 -0500 Message-ID: <50C86CDF.8010403@siemens.com> Date: Wed, 12 Dec 2012 12:39:11 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20121212104821.GA6324@redhat.com> In-Reply-To: <20121212104821.GA6324@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , "kvm@vger.kernel.org" , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity , "asias@redhat.com" On 2012-12-12 11:48, Michael S. Tsirkin wrote: > Deleting a GSI isn't necessary: it is enough > to stop using it. Delay flush until an entry is used. > > Signed-off-by: Michael S. Tsirkin > --- > kvm-all.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 3bc3347..fb3180d 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -991,8 +991,6 @@ void kvm_irqchip_release_virq(KVMState *s, int virq) > } > } > clear_gsi(s, virq); > - > - kvm_irqchip_commit_routes(s); > } > > static unsigned int kvm_hash_msi(uint32_t data) > Reviewed-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux