From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <barsamin@gmail.com>) id 1Tili3-0008PX-6U
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:46:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <barsamin@gmail.com>) id 1Tilhw-0004Wl-19
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:46:47 -0500
Received: from mail-la0-f45.google.com ([209.85.215.45]:37862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <barsamin@gmail.com>) id 1Tilhv-0004U8-K8
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 07:46:39 -0500
Received: by mail-la0-f45.google.com with SMTP id p9so546780laa.4
	for <qemu-devel@nongnu.org>; Wed, 12 Dec 2012 04:46:38 -0800 (PST)
Message-ID: <50C87C9F.8070904@gmail.com>
Date: Wed, 12 Dec 2012 13:46:23 +0100
From: Antoine Mathys <barsamin@gmail.com>
MIME-Version: 1.0
References: <50C7B767.8020406@gmail.com> <50C7BA7A.5060705@gmail.com>
	<CAFEAcA9EOVWeJX+uF7mMoSnoktQM8wedAPNFsQWw7jCcJhFL3g@mail.gmail.com>
In-Reply-To: <CAFEAcA9EOVWeJX+uF7mMoSnoktQM8wedAPNFsQWw7jCcJhFL3g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is
	properly initialized.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com

On 12/12/2012 01:05 PM, Peter Maydell wrote:
> I think we need to reset ptr and addr_byte too...
The initial value of the register pointer is unspecified.

addr_byte is only used when receiving user data. It is written in 
ds1338_event() then read in ds1338_send(). Setting it in ds1338_reset() 
is unnecessary and would break encapsulation.