From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Timj4-0005Zo-HX for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Timiy-0004ov-Da for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:51:54 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36284 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Timiy-0004oj-3x for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:51:48 -0500 Message-ID: <50C88BED.6000000@suse.de> Date: Wed, 12 Dec 2012 14:51:41 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355317734-55761-1-git-send-email-jfrei@linux.vnet.ibm.com> <1355317734-55761-4-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1355317734-55761-4-git-send-email-jfrei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jens Freimann Cc: Heinz Graalfs , Alexander Graf , qemu-devel , Christian Borntraeger , Cornelia Huck , Viktor Mihajlovski , Einar Lueck , Richard Henderson Am 12.12.2012 14:08, schrieb Jens Freimann: > From: Viktor Mihajlovski >=20 > This enables qemu -cpu help to return a list of supported CPU models > on s390 and also to query for cpu definitions in the monitor. > Initially only cpu model =3D host is returned. This needs to be reworke= d > into a full-fledged CPU model handling later on. > This change is needed to allow libvirt exploiters (like OpenStack) > to specify a CPU model. >=20 > Signed-off-by: Viktor Mihajlovski > Signed-off-by: Jens Freimann > Reviewed-by: Christian Borntraeger > --- > hw/s390-virtio.c | 6 +++++- > target-s390x/cpu.c | 21 +++++++++++++++++++++ > target-s390x/cpu.h | 3 +++ > 3 files changed, 29 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c > index 18050b1..5d4dd43 100644 > --- a/hw/s390-virtio.c > +++ b/hw/s390-virtio.c > @@ -2,6 +2,7 @@ > * QEMU S390 virtio target > * > * Copyright (c) 2009 Alexander Graf > + * Copyright IBM Corp 2012 > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -13,7 +14,10 @@ > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > * Lesser General Public License for more details. > * > - * You should have received a copy of the GNU Lesser General Public > + * Contributions after 2012-10-29 are licensed under the terms of the > + * GNU GPL, version 2 or (at your option) any later version. > + * > + * You should have received a copy of the GNU (Lesser) General Public > * License along with this library; if not, see . > */ > =20 > diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c > index 75f60b3..4a8562b 100644 > --- a/target-s390x/cpu.c > +++ b/target-s390x/cpu.c > @@ -28,8 +28,29 @@ > #include "hw/hw.h" > #include "qemu-common.h" > #include "qemu-timer.h" > +#include "arch_init.h" > =20 > =20 > +/* generate CPU information for cpu -? */ > +void s390_cpu_list(FILE *f, fprintf_function cpu_fprintf) > +{ > + (*cpu_fprintf)(f, "s390 %16s\n", "[host]"); Note that the square-bracket notation was specific to x86 when it distinguished between built-in and config-based models. > +} > + > +CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp) > +{ > + CpuDefinitionInfoList *entry; > + CpuDefinitionInfo *info; > + > + info =3D g_malloc0(sizeof(*info)); > + info->name =3D g_strdup("host"); > + > + entry =3D g_malloc0(sizeof(*entry)); > + entry->value =3D info; > + > + return entry; > +} "host" only makes sense for KVM, not for TCG. So we would need one other placeholder model for libvirt. In cpu_s390x_init() a check should be added to reject "host" if !kvm_enabled(). Background is that in the CPU subclasses world we would want to derive a "host-s390-cpu" here and not let that be instantiated outside KVM. Then we do need one always instantiatible model though. Regards, Andreas > + > /* CPUClass::reset() */ > static void s390_cpu_reset(CPUState *s) > { > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h > index 0f9a1f7..3513976 100644 > --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -350,6 +350,9 @@ static inline void cpu_set_tls(CPUS390XState *env, = target_ulong newtls) > #define cpu_gen_code cpu_s390x_gen_code > #define cpu_signal_handler cpu_s390x_signal_handler > =20 > +void s390_cpu_list(FILE *f, fprintf_function cpu_fprintf); > +#define cpu_list s390_cpu_list > + > #include "exec-all.h" > =20 > #ifdef CONFIG_USER_ONLY >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg