From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TinQC-0003yx-3o
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:36:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TinQ2-0008WK-Kb
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:36:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TinQ2-0008W5-DJ
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:36:18 -0500
Message-ID: <50C8965A.7020004@redhat.com>
Date: Wed, 12 Dec 2012 15:36:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20121212105101.GA6461@redhat.com>
	<20121212135050.GC16270@stefanha-thinkpad.redhat.com>
	<50C88E53.4080200@redhat.com> <20121212143038.GD15555@redhat.com>
In-Reply-To: <20121212143038.GD15555@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding
 buffers are flushed
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Il 12/12/2012 15:30, Michael S. Tsirkin ha scritto:
> > Same for virtio-scsi.  Each request in that case is sent as part of the
> > SCSIDevice that it refers to, via callbacks in SCSIBusInfo.

It is in virtio_scsi_load_request.

> Looks like this will leak ring entries.
> 
> All I see is: virtio_scsi_load calling virtio_load.
> When the loading side will get last avail index it
> will assume all requests up to that value have
> completed, so it will never put the missing heads
> in the used ring.

Ok, so we need some API for virtio-{blk,scsi} to communicate back the
indexes of in-flight requests to virtio.  The indexes are known from the
VirtQueueElement, so that's fine.

Even better would be a virtio_save_request/virtio_load_request API...

Paolo