From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TinZI-00066e-65 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:45:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TinZA-0002fB-At for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:45:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TinZ9-0002f3-Tt for qemu-devel@nongnu.org; Wed, 12 Dec 2012 09:45:44 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCEjgjJ012981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 09:45:42 -0500 Received: from ulublin.csb (dhcp-4-37.tlv.redhat.com [10.35.4.37]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCEjfAU026257 for ; Wed, 12 Dec 2012 09:45:42 -0500 Message-ID: <50C89895.8080704@redhat.com> Date: Wed, 12 Dec 2012 16:45:41 +0200 From: Uri Lublin MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server Reply-To: uril@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/10/2012 12:36 PM, Uri Lublin wrote: > When qxl + vnc are used, a dummy spice_server is initialized. > The spice_server has to be told when the VM runstate changes, > which is what this patch does. > > Without it, from qxl_send_events(), the following error message is shown: > qxl_send_events: spice-server bug: guest stopped, ignoring Signed-off-by: Uri Lublin > --- > ui/spice-core.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 261c6f2..6a6ab12 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -732,6 +732,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin) > */ > spice_server = spice_server_new(); > spice_server_init(spice_server,&core_interface); > + qemu_add_vm_change_state_handler(vm_change_state_handler,&spice_server); > } > > return spice_server_add_interface(spice_server, sin);