From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mihajlov@linux.vnet.ibm.com>) id 1TinsK-00075C-Mj
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:05:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mihajlov@linux.vnet.ibm.com>) id 1TinsD-00083Q-Oo
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:05:32 -0500
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:42463)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mihajlov@linux.vnet.ibm.com>) id 1TinsD-00082c-Ft
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:05:25 -0500
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mihajlov@linux.vnet.ibm.com>;
	Wed, 12 Dec 2012 15:05:10 -0000
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id qBCF5E9T63635672
	for <qemu-devel@nongnu.org>; Wed, 12 Dec 2012 15:05:14 GMT
Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain
	[127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id qBCF5Lc7007249
	for <qemu-devel@nongnu.org>; Wed, 12 Dec 2012 08:05:22 -0700
Message-ID: <50C89D30.4020508@linux.vnet.ibm.com>
Date: Wed, 12 Dec 2012 16:05:20 +0100
From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1355317734-55761-1-git-send-email-jfrei@linux.vnet.ibm.com>
	<1355317734-55761-4-git-send-email-jfrei@linux.vnet.ibm.com>
	<50C88BED.6000000@suse.de>
In-Reply-To: <50C88BED.6000000@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP
	query-cpu-definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Einar Lueck <elelueck@linux.vnet.ibm.com>, Richard Henderson <rth@twiddle.net>

On 12/12/2012 02:51 PM, Andreas Färber wrote:
>> +    (*cpu_fprintf)(f, "s390 %16s\n", "[host]");
>
> Note that the square-bracket notation was specific to x86 when it
> distinguished between built-in and config-based models.
>
OK, since libvirt capable of dealing with s390 cpu models will
never see this, we can change it any way that is wanted.
So, host without brackets?
> "host" only makes sense for KVM, not for TCG. So we would need one other
> placeholder model for libvirt.
see my reply to Alex' comment: the placeholder name must be chosen
carefully, i.e. future-proof

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294