From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@dlhnet.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] iscsi: add support for iovectors
Date: Wed, 12 Dec 2012 16:25:12 +0100 [thread overview]
Message-ID: <50C8A1D8.3030100@redhat.com> (raw)
In-Reply-To: <50C8A178.4040307@dlhnet.de>
Il 12/12/2012 16:23, Peter Lieven ha scritto:
>>> >> +#if defined(LIBISCSI_FEATURE_IOVECTOR)
>>> >> + if (iscsi_scsi_command_async(iscsi, iscsilun->lun, acb->task,
>>> >> + iscsi_aio_write16_cb,
>>> >> + NULL,
>>> >> + acb) != 0) {
>>> >> + scsi_free_scsi_task(acb->task);
>>> >> + qemu_aio_release(acb);
>>> >> + return NULL;
>>> >> + }
>>> >> + scsi_task_set_iov_out(acb->task, (struct scsi_iovec*) acb->qiov->iov, acb->qiov->niov);
>> >
>> > Are you sure that scsi_task_set_iov_out must be called _after_
>> > submitting the command?
> This does not matter since iscsi_scsi_command_async() will only queue
> the command pdu. The iov has to be set when iscsi_service() is called
> which will actually send out the PDUs + payload to the socket.
Ok, I queued the patch to scsi-next branch.
Paolo
prev parent reply other threads:[~2012-12-12 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 19:35 [Qemu-devel] [PATCH] iscsi: add support for iovectors Peter Lieven
2012-12-12 13:57 ` Paolo Bonzini
2012-12-12 15:23 ` Peter Lieven
2012-12-12 15:25 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8A1D8.3030100@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).