From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49256)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TioBX-000237-9J
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:25:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TioBR-00050f-F3
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:25:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TioBR-00050X-7X
	for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:25:17 -0500
Message-ID: <50C8A1D8.3030100@redhat.com>
Date: Wed, 12 Dec 2012 16:25:12 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <50BCFEF3.4070805@dlhnet.de> <50C88D5B.9020403@redhat.com>
	<50C8A178.4040307@dlhnet.de>
In-Reply-To: <50C8A178.4040307@dlhnet.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iscsi: add support for iovectors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@dlhnet.de>
Cc: Kevin Wolf <kwolf@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, ronnie sahlberg <ronniesahlberg@gmail.com>

Il 12/12/2012 16:23, Peter Lieven ha scritto:
>>> >> +#if defined(LIBISCSI_FEATURE_IOVECTOR)
>>> >> +    if (iscsi_scsi_command_async(iscsi, iscsilun->lun, acb->task,
>>> >> +                                 iscsi_aio_write16_cb,
>>> >> +                                 NULL,
>>> >> +                                 acb) != 0) {
>>> >> +        scsi_free_scsi_task(acb->task);
>>> >> +        qemu_aio_release(acb);
>>> >> +        return NULL;
>>> >> +    }
>>> >> +    scsi_task_set_iov_out(acb->task, (struct scsi_iovec*) acb->qiov->iov, acb->qiov->niov);
>> > 
>> > Are you sure that scsi_task_set_iov_out must be called _after_
>> > submitting the command?
> This does not matter since iscsi_scsi_command_async() will only queue
> the command pdu. The iov has to be set when iscsi_service() is called
> which will actually send out the PDUs + payload to the socket.

Ok, I queued the patch to scsi-next branch.

Paolo