From: Gerd Hoffmann <kraxel@redhat.com>
To: uril@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server
Date: Wed, 12 Dec 2012 16:31:12 +0100 [thread overview]
Message-ID: <50C8A340.10507@redhat.com> (raw)
In-Reply-To: <50C89895.8080704@redhat.com>
On 12/12/12 15:45, Uri Lublin wrote:
> On 12/10/2012 12:36 PM, Uri Lublin wrote:
>> When qxl + vnc are used, a dummy spice_server is initialized.
>> The spice_server has to be told when the VM runstate changes,
>> which is what this patch does.
>>
>> Without it, from qxl_send_events(), the following error message is shown:
>> qxl_send_events: spice-server bug: guest stopped, ignoring
>
> Signed-off-by: Uri Lublin <uril@redhat.com>
=== checkpatch complains ===
WARNING: line over 80 characters
#10: FILE: ui/spice-core.c:739:
+ qemu_add_vm_change_state_handler(vm_change_state_handler,
&spice_server);
please fix & resend.
thanks,
Gerd
prev parent reply other threads:[~2012-12-12 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 10:36 [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server Uri Lublin
2012-12-12 14:45 ` Uri Lublin
2012-12-12 15:31 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8A340.10507@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).