From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioHI-0007zd-LF for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:31:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TioHC-0006Yq-U3 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:31:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TioHC-0006Yh-NI for qemu-devel@nongnu.org; Wed, 12 Dec 2012 10:31:14 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCFVEDp010827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 10:31:14 -0500 Message-ID: <50C8A340.10507@redhat.com> Date: Wed, 12 Dec 2012 16:31:12 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <50C89895.8080704@redhat.com> In-Reply-To: <50C89895.8080704@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: uril@redhat.com Cc: qemu-devel@nongnu.org On 12/12/12 15:45, Uri Lublin wrote: > On 12/10/2012 12:36 PM, Uri Lublin wrote: >> When qxl + vnc are used, a dummy spice_server is initialized. >> The spice_server has to be told when the VM runstate changes, >> which is what this patch does. >> >> Without it, from qxl_send_events(), the following error message is shown: >> qxl_send_events: spice-server bug: guest stopped, ignoring > > Signed-off-by: Uri Lublin === checkpatch complains === WARNING: line over 80 characters #10: FILE: ui/spice-core.c:739: + qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server); please fix & resend. thanks, Gerd