From: Alexander Graf <agraf@suse.de>
To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: "Heinz Graalfs" <graalfs@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Einar Lueck" <elelueck@linux.vnet.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Jens Freimann" <jfrei@linux.vnet.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions
Date: Wed, 12 Dec 2012 16:50:34 +0100 [thread overview]
Message-ID: <50C8A7CA.8090904@suse.de> (raw)
In-Reply-To: <50C89D30.4020508@linux.vnet.ibm.com>
On 12/12/2012 04:05 PM, Viktor Mihajlovski wrote:
> On 12/12/2012 02:51 PM, Andreas Färber wrote:
>>> + (*cpu_fprintf)(f, "s390 %16s\n", "[host]");
>>
>> Note that the square-bracket notation was specific to x86 when it
>> distinguished between built-in and config-based models.
>>
> OK, since libvirt capable of dealing with s390 cpu models will
> never see this, we can change it any way that is wanted.
> So, host without brackets?
>> "host" only makes sense for KVM, not for TCG. So we would need one other
>> placeholder model for libvirt.
> see my reply to Alex' comment: the placeholder name must be chosen
> carefully, i.e. future-proof
Yeah, it's perfectly fine for me to ignore the model name in the code
today (as we do iirc) and only add the host target for starters. Though
that one should do a kvm_enabled() check.
Alex
next prev parent reply other threads:[~2012-12-12 15:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 13:08 [Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support Jens Freimann
2012-12-12 13:08 ` [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device Jens Freimann
2012-12-12 13:31 ` Alexander Graf
2012-12-12 19:56 ` Christian Borntraeger
2012-12-12 13:08 ` [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler Jens Freimann
2012-12-12 13:38 ` Alexander Graf
2012-12-12 15:04 ` Jens Freimann
2012-12-12 13:08 ` [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions Jens Freimann
2012-12-12 13:40 ` Alexander Graf
2012-12-12 13:51 ` Andreas Färber
2012-12-12 14:03 ` Alexander Graf
2012-12-12 14:57 ` Viktor Mihajlovski
2012-12-12 17:52 ` Richard Henderson
2012-12-12 18:25 ` Alexander Graf
2012-12-12 15:05 ` Viktor Mihajlovski
2012-12-12 15:50 ` Alexander Graf [this message]
2012-12-12 16:28 ` Andreas Färber
2012-12-12 18:23 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2012-12-14 16:46 [Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support Jens Freimann
2012-12-14 16:46 ` [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions Jens Freimann
2012-12-16 15:42 ` Andreas Färber
2012-12-17 14:47 ` Alexander Graf
2012-12-17 17:32 ` Andreas Färber
2012-12-18 17:50 [Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support Jens Freimann
2012-12-18 17:50 ` [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions Jens Freimann
2013-01-03 13:01 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C8A7CA.8090904@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=elelueck@linux.vnet.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).