From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tiq6o-0004Os-Dk for qemu-devel@nongnu.org; Wed, 12 Dec 2012 12:28:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tiq6i-0006E6-07 for qemu-devel@nongnu.org; Wed, 12 Dec 2012 12:28:38 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:63851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TipKF-0007u6-NN for qemu-devel@nongnu.org; Wed, 12 Dec 2012 11:38:27 -0500 Received: by mail-ie0-f171.google.com with SMTP id 17so2251431iea.2 for ; Wed, 12 Dec 2012 08:38:27 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50C8B2FD.5030200@redhat.com> Date: Wed, 12 Dec 2012 17:38:21 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1355322396-32026-1-git-send-email-pbonzini@redhat.com> <20121212153821.GA17446@redhat.com> In-Reply-To: <20121212153821.GA17446@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, agraf@suse.de Il 12/12/2012 16:38, Michael S. Tsirkin ha scritto: >> > These patches fix this problem by calling qdev_reset_all when zero >> > is written to the status field. > Looks like this is a virtio-scsi thing - others don't have a hierarchy. virtio-serial does, and is doing the same walk manually. > Let's just stick this code in virtio_scsi_reset then? No. > It likely can access the scsi bus without going through virtio-pci > and s390 right? Yes, it can, but it's not a good reason to do it there. Paolo