From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tiqzm-0003a2-Km for qemu-devel@nongnu.org; Wed, 12 Dec 2012 13:25:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tiqzf-0006E6-Sz for qemu-devel@nongnu.org; Wed, 12 Dec 2012 13:25:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:50700 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tiqzf-0006Dx-MA for qemu-devel@nongnu.org; Wed, 12 Dec 2012 13:25:19 -0500 Message-ID: <50C8CC0C.8040106@suse.de> Date: Wed, 12 Dec 2012 19:25:16 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1355317734-55761-1-git-send-email-jfrei@linux.vnet.ibm.com> <1355317734-55761-4-git-send-email-jfrei@linux.vnet.ibm.com> <50C88BED.6000000@suse.de> <50C8C450.1090500@twiddle.net> In-Reply-To: <50C8C450.1090500@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Heinz Graalfs , Einar Lueck , qemu-devel , Viktor Mihajlovski , Christian Borntraeger , Jens Freimann , Cornelia Huck , =?ISO-8859-1?Q?Andreas_F=E4rber?= On 12/12/2012 06:52 PM, Richard Henderson wrote: > On 12/12/2012 06:03 AM, Alexander Graf wrote: >> The TCG model is a "z900". We can just have a "z900" model and a >> "host" model with tcg_enabled() vs kvm_enabled() checks on each. > My target-s390x tcg rewrite targets something just shy of z196. > > The main thing that's missing is actually STORE FACILITY LIST EXTENDED. > Which I always assumed would go along with a re-vamp of the cpu model, > just as we're considering here, so that we could in fact emulate z900 > or anything in between. Yes, and it's definitely something we need to do. I'm just concerned about timing. Do we want to hold back a bug fix (libvirt can break with empty cpu lists) for a feature (proper cpu list for tcg targets)? I'd say let's make the -cpu host target work and whoever gets around to it first can implement cpu models, store facility list extended, and tcg feature masks. Alex