From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tivw4-00069W-4u for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:41:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tivw3-0000lL-2E for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:41:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tivw2-0000lE-QM for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:41:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCNfrRD005652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 18:41:53 -0500 Message-ID: <50C9163F.30505@redhat.com> Date: Wed, 12 Dec 2012 16:41:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355319999-30627-1-git-send-email-pbonzini@redhat.com> <1355319999-30627-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1355319999-30627-2-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1452387F25AE3EFBB221AEFD" Subject: Re: [Qemu-devel] [PATCH 01/20] host-utils: add ffsl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1452387F25AE3EFBB221AEFD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > We can provide fast versions based on the other functions defined > by host-utils.h. Some care is required on glibc, which provides > ffsl already. >=20 > Signed-off-by: Paolo Bonzini > --- > host-utils.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) Reviewed-by: Eric Blake >=20 > diff --git a/host-utils.h b/host-utils.h > index 821db93..231d580 100644 > --- a/host-utils.h > +++ b/host-utils.h > @@ -24,6 +24,7 @@ > */ > =20 > #include "compiler.h" /* QEMU_GNUC_PREREQ */ > +#include /* ffsl */ I never really understood why ffs() is in but ffsl() is in , especially when neither function deals with strings (a header would have made more sense), but such is life. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1452387F25AE3EFBB221AEFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQyRY/AAoJEKeha0olJ0NqxOAH/j4tNZKHptveId1VXvevD8D8 bdHccq4SOEuiBCuKA66kZbKEe4bguByj3AVzKgdikUklhzOiE+rvfrQqEM3q6g5n CHsX3L1zx7EqZeqUg4KzikKlwdVsMxYGjnWIYTaiqVfQsDBXvkUubRJRw3wqxE9r kxUYdfcAjIw3FiPVOlIYL/1YwGQ+6O0npWU6MihqufdXw7b7eSIbrwSVYW75DICk TODxnKL5mfpCvBQK643Yb/T3wXgl8N5bob9Lm43Fa6R6Xy591iiF8HPe5wqLR588 Evp+p70V8VoviJqXCaa4IxzQdFlYUo5tD5oJ862HwijCE5LyRP8D013e0igEccw= =lm8a -----END PGP SIGNATURE----- --------------enig1452387F25AE3EFBB221AEFD--