From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj4bL-0004MC-58 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 03:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj4bJ-00066W-Gc for qemu-devel@nongnu.org; Thu, 13 Dec 2012 03:57:07 -0500 Received: from greensocs.com ([87.106.252.221]:39781 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj4bJ-000666-AK for qemu-devel@nongnu.org; Thu, 13 Dec 2012 03:57:05 -0500 Message-ID: <50C9985C.8020607@greensocs.com> Date: Thu, 13 Dec 2012 09:57:00 +0100 From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= MIME-Version: 1.0 References: <1355157952-2321-1-git-send-email-fred.konrad@greensocs.com> <1355157952-2321-8-git-send-email-fred.konrad@greensocs.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de On 11/12/2012 18:50, Peter Maydell wrote: > On 10 December 2012 16:45, wrote: >> From: KONRAD Frederic >> >> Here the virtio-blk-pci is modified for the new API. The device virtio-pci-blk >> extends virtio-pci. It creates and connects a virtio-blk during the init. > Did you check whether this maintains backwards compatibility > for vmstate migration information and device properties? > (haven't investigated myself yet, just asking whether you have) > > -- PMM What do you mean exactly by backwards compatibility for vmstate migration ? The device properties didn't change. The virtio-blk-pci creates a virtio-blk device, puts the virtio block properties and inits the virtio-blk.