From: Kevin Wolf <kwolf@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed
Date: Thu, 13 Dec 2012 11:48:17 +0100 [thread overview]
Message-ID: <50C9B271.2020906@redhat.com> (raw)
In-Reply-To: <20121212163713.GD17446@redhat.com>
Am 12.12.2012 17:37, schrieb Michael S. Tsirkin:
> On Wed, Dec 12, 2012 at 04:52:53PM +0100, Paolo Bonzini wrote:
>> Il 12/12/2012 16:25, Michael S. Tsirkin ha scritto:
>>> On Wed, Dec 12, 2012 at 04:01:27PM +0100, Paolo Bonzini wrote:
>>>> Il 12/12/2012 15:47, Michael S. Tsirkin ha scritto:
>>>>> As step 1, I think we should just complete all outstanding
>>>>> requests when VM stops.
>>>>>
>>>>> Yes it means you can't do the retry hack after migration
>>>>> but this is hardly common scenario.
>>>>
>>>> I disagree...
>>>
>>> Disagree with what? You are saying it's common?
>>
>> It's not common, but you cannot block migration because you have an I/O
>> error. Solving the error may involve migrating the guests away from
>> that host.
>>
>> Paolo
>
> No, you should complete with error.
Just to confirm that this isn't possible: rerror/werror=stop is a
supported feature, and I do get bug reports when it breaks (including
migration while the VM is stopped for an I/O error).
Makes it common enough that breaking it is definitely not an option, right?
Kevin
next prev parent reply other threads:[~2012-12-13 10:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 10:51 [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed Michael S. Tsirkin
2012-12-12 13:50 ` Stefan Hajnoczi
2012-12-12 14:01 ` Paolo Bonzini
2012-12-12 14:30 ` Michael S. Tsirkin
2012-12-12 14:36 ` Paolo Bonzini
2012-12-12 14:47 ` Michael S. Tsirkin
2012-12-12 15:01 ` Paolo Bonzini
2012-12-12 15:25 ` Michael S. Tsirkin
2012-12-12 15:52 ` Paolo Bonzini
2012-12-12 16:37 ` Michael S. Tsirkin
2012-12-12 16:51 ` Paolo Bonzini
2012-12-12 17:14 ` Michael S. Tsirkin
2012-12-12 17:39 ` Paolo Bonzini
2012-12-12 19:23 ` Michael S. Tsirkin
2012-12-12 21:00 ` Paolo Bonzini
2012-12-12 21:19 ` Michael S. Tsirkin
2012-12-12 21:33 ` Anthony Liguori
2012-12-12 21:51 ` Michael S. Tsirkin
2012-12-14 1:06 ` Rusty Russell
2012-12-14 7:51 ` Paolo Bonzini
2012-12-16 20:36 ` Anthony Liguori
2012-12-13 7:39 ` Paolo Bonzini
2012-12-13 10:48 ` Kevin Wolf [this message]
2012-12-16 16:14 ` Michael S. Tsirkin
2012-12-12 14:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C9B271.2020906@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).