From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version
Date: Thu, 13 Dec 2012 16:30:20 +0100 [thread overview]
Message-ID: <50C9F48C.80900@redhat.com> (raw)
In-Reply-To: <9883CB56-0ED6-45B1-8B8B-773AC550AFB7@suse.de>
Hi,
> 6e72719e721a40fe1224701ca10edc1caf0cd708
It's broken, version is wrong, and I told you.
Seems you sneaked it in nevertheless.
> You had 2 branches that were using a new flag, one of which you had
> an #ifdef around and one of which you didn't. This is all fixed for
> quite a while now :).
Can you check which of your pixman versions have PIXMAN_TYPE_BGRA?
0.18.4 has it
0.12.0 has not
The 0.16.x versions would be interesting so we can fix the #ifdef to be
correct (or at least correct enougth for all practical purposes).
> If that's the culprit for all this mess, can we remove the configure
> check again? QEMU compiles just fine without it today on pixman
> 0.12.0.
If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 I'll
go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
cheers,
Gerd
next prev parent reply other threads:[~2012-12-13 16:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 12:48 [Qemu-devel] [PATCH 0/2] pixman: two little fixes Gerd Hoffmann
2012-12-10 12:48 ` [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version Gerd Hoffmann
2012-12-13 14:31 ` Alexander Graf
2012-12-13 14:48 ` Gerd Hoffmann
2012-12-13 14:50 ` Alexander Graf
2012-12-13 15:30 ` Gerd Hoffmann [this message]
2012-12-13 16:10 ` Alexander Graf
2012-12-14 7:54 ` Gerd Hoffmann
2012-12-14 9:57 ` Alexander Graf
2012-12-13 14:56 ` Alexander Graf
2012-12-10 12:48 ` [Qemu-devel] [PATCH 2/2] pixman: update internal copy to pixman-0.28.2 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C9F48C.80900@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).