From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjBGg-0005qT-Ll
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 11:04:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjBGf-000445-Hf
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 11:04:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16090)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjBGf-00043y-B8
	for qemu-devel@nongnu.org; Thu, 13 Dec 2012 11:04:13 -0500
Message-ID: <50C9F48C.80900@redhat.com>
Date: Thu, 13 Dec 2012 16:30:20 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1355143684-16850-1-git-send-email-kraxel@redhat.com>
	<1355143684-16850-2-git-send-email-kraxel@redhat.com>
	<5EEEC17D-B803-482A-9BD8-9600ABE58EA9@suse.de>
	<50C9EAA6.7080309@redhat.com>
	<9883CB56-0ED6-45B1-8B8B-773AC550AFB7@suse.de>
In-Reply-To: <9883CB56-0ED6-45B1-8B8B-773AC550AFB7@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum
	version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

  Hi,

> 6e72719e721a40fe1224701ca10edc1caf0cd708

It's broken, version is wrong, and I told you.
Seems you sneaked it in nevertheless.

> You had 2 branches that were using a new flag, one of which you had
> an #ifdef around and one of which you didn't. This is all fixed for
> quite a while now :).

Can you check which of your pixman versions have PIXMAN_TYPE_BGRA?

0.18.4 has it
0.12.0 has not

The 0.16.x  versions would be interesting so we can fix the #ifdef to be
correct (or at least correct enougth for all practical purposes).

> If that's the culprit for all this mess, can we remove the configure
> check again? QEMU compiles just fine without it today on pixman
> 0.12.0.

If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 I'll
go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae

cheers,
  Gerd