From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjIls-0001Z5-7V for qemu-devel@nongnu.org; Thu, 13 Dec 2012 19:05:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjIlo-0004jx-3c for qemu-devel@nongnu.org; Thu, 13 Dec 2012 19:04:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjIln-0004jp-S7 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 19:04:52 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBE04odU023889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Dec 2012 19:04:50 -0500 Message-ID: <50CA6D20.80705@redhat.com> Date: Thu, 13 Dec 2012 17:04:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355319999-30627-1-git-send-email-pbonzini@redhat.com> <1355319999-30627-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1355319999-30627-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig21B88369B49A066CDED6BF9E" Subject: Re: [Qemu-devel] [PATCH 02/20] add hierarchical bitmap data type and test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig21B88369B49A066CDED6BF9E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > HBitmaps provides an array of bits. The bits are stored as usual in an= > array of unsigned longs, but HBitmap is also optimized to provide fast > iteration over set bits; going from one bit to the next is O(logB n) > worst case, with B =3D sizeof(long) * CHAR_BIT: the result is low enoug= h > that the number of levels is in fact fixed. >=20 >=20 > Reviewed-by: Laszlo Ersek > Signed-off-by: Paolo Bonzini > --- > hbitmap.c | 400 +++++++++++++++++++++++++++++++++++++++++++= +++++++ > hbitmap.h | 207 ++++++++++++++++++++++++++ > tests/Makefile | 2 + > tests/test-hbitmap.c | 408 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > trace-events | 5 + > 5 files changed, 1022 insertions(+) > create mode 100644 hbitmap.c > create mode 100644 hbitmap.h > create mode 100644 tests/test-hbitmap.c I've looked through this several times, but did another once-over, and you can feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig21B88369B49A066CDED6BF9E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQym0gAAoJEKeha0olJ0NqsoYH/RCVfl3wu2HdHyaL1bPW/WGK CsJ+PDaHwC3WzJ3HejzH0kF2Oc6Xu1haSZo1VK1GsKbbHWpRzesGScrKqabojlxu bvpviOVT8IirOaFvBghYhs6VzwFpMi3lCsQScp+PvygLcLwqdcuZ0ctJqmcdQfyv Tl/q82sCM5jp2XfH8Vfs7mHTCQ4PAcGK9Q8PJyfaMoHPXcmQOyPOlll+xPZTH5ZK HzOcIxBjKG05iuQvJNlgVP75eqMWbND4SNXgiWeu9F3r60KG4iv4iHqjXoMPFo4v uogGQv1bwLcT+dKlLkHoO1+FX5Gh6gHTwpWiN9zC4ldjlYRg3OnQpk57q4Bn6zU= =mzSy -----END PGP SIGNATURE----- --------------enig21B88369B49A066CDED6BF9E--