From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjQ61-0005zk-7k for qemu-devel@nongnu.org; Fri, 14 Dec 2012 02:54:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjQ60-0005is-1a for qemu-devel@nongnu.org; Fri, 14 Dec 2012 02:54:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjQ5z-0005ij-Pp for qemu-devel@nongnu.org; Fri, 14 Dec 2012 02:54:11 -0500 Message-ID: <50CADB20.9010308@redhat.com> Date: Fri, 14 Dec 2012 08:54:08 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355143684-16850-1-git-send-email-kraxel@redhat.com> <1355143684-16850-2-git-send-email-kraxel@redhat.com> <5EEEC17D-B803-482A-9BD8-9600ABE58EA9@suse.de> <50C9EAA6.7080309@redhat.com> <9883CB56-0ED6-45B1-8B8B-773AC550AFB7@suse.de> <50C9F48C.80900@redhat.com> <79C05D8D-072A-40C9-8CEB-2C7350C2A8E7@suse.de> In-Reply-To: <79C05D8D-072A-40C9-8CEB-2C7350C2A8E7@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org Hi, >> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 >> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae > > 6e72719 is perfectly sane, because it brings consistency into the > file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same > #ifdef. Both users? Hello? Its two *different* types: PIXMAN_TYPE_RGBA and PIXMAN_TYPE_BGRA. And, yes, they have been added in different versions. So guarding them with the *same* #ifdef is wrong. > #ifdef PIXMAN_TYPE_BGRA It's a enum, not a #define, so this isn't going to fly. cheers, Gerd