From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjW6m-000641-1t
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 09:19:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjW6k-0000YP-61
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 09:19:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59498)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TjW6j-0000YB-TV
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 09:19:22 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEEJL8X032014
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 Dec 2012 09:19:21 -0500
Message-ID: <50CB3562.5030007@redhat.com>
Date: Fri, 14 Dec 2012 15:19:14 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1355477883-15728-1-git-send-email-kraxel@redhat.com>
	<1355477883-15728-4-git-send-email-kraxel@redhat.com>
	<50CB18E1.90706@redhat.com> <50CB272C.5020103@redhat.com>
	<50CB2D64.2030408@redhat.com> <50CB3219.8000804@redhat.com>
In-Reply-To: <50CB3219.8000804@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

>> ... are you passing a file descriptor for a pipe, a file or a
>> parallel/serial port?
> 
> The open function of the file-based backends basically do (1) create
> file handles and (2) call qemu_chr_open_fd().  So of you already have an
> fd the differences are gone.  Well, almost.  tty has an special ioctl
> callback to configure line speed.

Also you might want to pass in a socket fd ...

So I really think a -chardev
fd,type={listening-stream-socket,connected-stream-socket,datagram-socket,tty,fd-readwrite,fd-writeonly}
(+ QMP for that) will be more useful.

cheers,
  Gerd