From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50121)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TjXLj-0001m0-6i
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:38:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TjXLh-0002UV-VG
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:38:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62643)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TjXLh-0002UQ-O8
	for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:38:53 -0500
Message-ID: <50CB4808.4030005@redhat.com>
Date: Fri, 14 Dec 2012 16:38:48 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1354726153-30264-1-git-send-email-ehabkost@redhat.com>
	<1354726153-30264-2-git-send-email-ehabkost@redhat.com>
	<50CB4705.80609@suse.de>
In-Reply-To: <50CB4705.80609@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler
 flag to Makefile.objs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>, Don Slutz <Don@CloudSwitch.Com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Il 14/12/2012 16:34, Andreas F=E4rber ha scritto:
> Am 05.12.2012 17:49, schrieb Eduardo Habkost:
>> The flag is necessary for code that doesn't use the variables from
>> Makefile (but use Makefile.objs), like libcacard/ and stubs/.
>>
>> This also moves the existing CFLAGS lines from Makefile.objs at the
>> beginning of the file, to keep them all in the same place.
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>=20
> Waiting for ack or nack from Paolo here. I am expecting some overlap
> with his header file reorganization series.

Yeah, I expect that series to go in early next week.  Waiting for Blue
to pull from Alexander.

Paolo

> My previous (unanswered?) question was why you are moving vl.o lines in
> addition to the QEMU_CFLAGS lines that you mention in the commit messag=
e.
>=20
> Andreas
>=20
>> ---
>>  Makefile      |  1 -
>>  Makefile.objs | 15 +++++++++------
>>  2 files changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 9ecbcbb..739d9cd 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -145,7 +145,6 @@ audio/audio.o audio/fmodaudio.o: QEMU_CFLAGS +=3D =
$(FMOD_CFLAGS)
>> =20
>>  QEMU_CFLAGS+=3D$(CURL_CFLAGS)
>> =20
>> -QEMU_CFLAGS +=3D -I$(SRC_PATH)/include
>> =20
>>  ui/cocoa.o: ui/cocoa.m
>> =20
>> diff --git a/Makefile.objs b/Makefile.objs
>> index 3c7abca..0a0a33a 100644
>> --- a/Makefile.objs
>> +++ b/Makefile.objs
>> @@ -1,4 +1,13 @@
>>  #####################################################################=
##
>> +# general compiler flags
>> +
>> +QEMU_CFLAGS +=3D $(GLIB_CFLAGS)
>> +QEMU_CFLAGS +=3D -I$(SRC_PATH)/include
>> +
>> +vl.o: QEMU_CFLAGS+=3D$(GPROF_CFLAGS)
>> +vl.o: QEMU_CFLAGS+=3D$(SDL_CFLAGS)
>> +
>> +#####################################################################=
##
>>  # Stub library, linked in tools
>>  stub-obj-y =3D stubs/
>> =20
>> @@ -236,12 +245,6 @@ universal-obj-y +=3D $(qapi-obj-y)
>>  qga-obj-y =3D qga/ qemu-ga.o module.o qemu-tool.o
>>  qga-obj-$(CONFIG_POSIX) +=3D qemu-sockets.o qemu-option.o
>> =20
>> -vl.o: QEMU_CFLAGS+=3D$(GPROF_CFLAGS)
>> -
>> -vl.o: QEMU_CFLAGS+=3D$(SDL_CFLAGS)
>> -
>> -QEMU_CFLAGS+=3D$(GLIB_CFLAGS)
>> -
>>  nested-vars +=3D \
>>  	stub-obj-y \
>>  	qga-obj-y \
>>
>=20
>=20