From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjXRo-0004Lg-U8 for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:45:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjXRk-00047T-Aa for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:45:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47025 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjXRk-0003lj-4D for qemu-devel@nongnu.org; Fri, 14 Dec 2012 10:45:08 -0500 Message-ID: <50CB4958.3080102@suse.de> Date: Fri, 14 Dec 2012 16:44:24 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354726153-30264-1-git-send-email-ehabkost@redhat.com> <1354726153-30264-9-git-send-email-ehabkost@redhat.com> <50C887D0.7050704@suse.de> <20121212135901.GD3236@otherpad.lan.raisama.net> <20121212152724.7693d277@nial.usersys.redhat.com> <50CB45CF.5000709@suse.de> <50CB4851.6040208@redhat.com> In-Reply-To: <50CB4851.6040208@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Igor Mammedov , Don Slutz , Eduardo Habkost , Anthony Liguori , qemu-devel@nongnu.org Am 14.12.2012 16:40, schrieb Paolo Bonzini: > Il 14/12/2012 16:29, Andreas F=E4rber ha scritto: >> The latest motivation for making the CPU a device was to have the stat= ic >> properties infrastructure for machine/CPU versioning. The global >> property defaults are set in qdev's instance_init, so object_new() see= ms >> fine for that. >> >> qdev_[try_]create() would further set the parent bus to SysBus if NULL= . >> The CPU is not a SysBusDevice so I think not using qdev_create() may b= e >> safer... Maybe Anthony or Paolo can confirm? >=20 > I think various parts of qdev assume there is a bus, so actually using > SysBus would be safer (though uglier). Hm, Anthony told me with one of his qbus refactoring patches back in qom-next the last remaining assumptions (info qdm) were removed... Probably we're the first to test though. ;) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg