From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjYlB-0007GL-3d for qemu-devel@nongnu.org; Fri, 14 Dec 2012 12:09:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjYl9-0000qD-VG for qemu-devel@nongnu.org; Fri, 14 Dec 2012 12:09:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjYl9-0000q0-Lp for qemu-devel@nongnu.org; Fri, 14 Dec 2012 12:09:15 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEH9EYa021092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Dec 2012 12:09:15 -0500 Message-ID: <50CB5D38.8070908@redhat.com> Date: Fri, 14 Dec 2012 10:09:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <97a424082acd2a43350e39347b24d15836c9a682.1355404685.git.phrdina@redhat.com> <20121214145728.6d1d1b67@doriath.home> In-Reply-To: <20121214145728.6d1d1b67@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6B25EC365FEC9E158B2B9396" Subject: Re: [Qemu-devel] [PATCH v2 13/17] qapi: Convert savevm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Pavel Hrdina , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6B25EC365FEC9E158B2B9396 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/14/2012 09:57 AM, Luiz Capitulino wrote: >> +## >> +# @vm-snapshot-save: >> +# >> +# Create a snapshot of the whole virtual machine. If tag is provided = as @name, >> +# it is used as human readable identifier. If there is already a snap= shot >> +# with the same tag or ID, it is replaced. >> +# >> +# The VM is automatically stopped and resumed and saving a snapshot c= an take >> +# a long time. >> +# >> +# @name: #optional tag of new snapshot or tag|id of existing snapshot= >=20 > I wonder if we should allow 'name' to be optional in QMP. Libvirt will always pass a 'name'. Where it gets confusing is that 'name' can be all digits; so if I say a name of '3', but it gets id '2', then future operations get way confusing (especially if later we also create a snapshot whose id becomes 3). >=20 >> +# >> +# Returns: Nothing on success One thing is for certain - if 'name' remains optional, then you MUST return the 'id' that was auto-allocated. And even if name is not optional, returning the 'id' that was either auto-allocated or successfully looked up as an existing snapshot would be more useful than returning nothing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6B25EC365FEC9E158B2B9396 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQy104AAoJEKeha0olJ0NqXtMH/2wthMKE/AsesyyYKG1YCq7Q pReBYGs/CuqA5I+kvABIlBdX7nrxw56HyEU8SzcsxCPS6of3seetdPQZc6QH9DIp aqTDYWAY99gA0ZElPHjzzQAD9SqUgsWyVnyYqWqkKHVoP0SE1v/Pe25yrgo5ykK+ WCIlr5kmSm1+fX0gssUIlZTRkNlFofoHja4I7Uq/l9JE7NUxCWPGjdLUHnXhnriL 9tw5yH02Xv7Mz38H3W5qn8m8WIFY/Co4kxQL9FbmvzezTmYSnLU5PTyruxqgW57J Cn9/Ih5pQvmxhG/HbBA0sgnU1hCSeNcrxtNkMVKQMnvtd3otRq1XR0h5dGoB/OY= =Mv3k -----END PGP SIGNATURE----- --------------enig6B25EC365FEC9E158B2B9396--