From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjdny-0005TT-VC for qemu-devel@nongnu.org; Fri, 14 Dec 2012 17:32:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tjdnu-0004zC-RM for qemu-devel@nongnu.org; Fri, 14 Dec 2012 17:32:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tjdnu-0004z8-IF for qemu-devel@nongnu.org; Fri, 14 Dec 2012 17:32:26 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEMWPrf005564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Dec 2012 17:32:25 -0500 Message-ID: <50CBA8F8.6010709@redhat.com> Date: Fri, 14 Dec 2012 15:32:24 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355319999-30627-1-git-send-email-pbonzini@redhat.com> <1355319999-30627-12-git-send-email-pbonzini@redhat.com> In-Reply-To: <1355319999-30627-12-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig795648CD05CFCA922A2CF770" Subject: Re: [Qemu-devel] [PATCH 11/20] mirror: support more than one in-flight AIO operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig795648CD05CFCA922A2CF770 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > With AIO support in place, we can start copying more than one chunk > in parallel. This patch introduces the required infrastructure for > this: the buffer is split into multiple granularity-sized chunks, > and there is a free list to access them. >=20 > Because of copy-on-write, a single operation may already require > multiple chunks to be available on the free list. >=20 > In addition, two different iterations on the HBitmap may want to > copy the same cluster. We avoid this by keeping a bitmap of in-flight > I/O operations, and blocking until the previous iteration completes. > This should be a pretty rare occurrence, though; as long as there is > no overlap the next iteration can start before the previous one finishe= s. >=20 > Signed-off-by: Paolo Bonzini > --- > block/mirror.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++= +------- > trace-events | 4 ++- > 2 files changed, 100 insertions(+), 13 deletions(-) Again, my review is weak, but feel free to add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig795648CD05CFCA922A2CF770 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQy6j4AAoJEKeha0olJ0NqfZEIAI7TqHwViGyveDHUQVIKE1HD MqoTh0rago2EkGbP2YuPrKGteDIM+RQmJolYck9SoQAKSFL403Uu91ivYPtQR7Oc /4aXKCtIThpR+l7e2j3jneMXSJmYb+I1KDVp3h222/Jq6O+oGTztzKYQ7zJNnLuB qa6RjC23dpqH6PEKa4oJHqMpku+5BOGyoth9W5/TTIgnMZd/cKgnnKCyVaZJtFDd JcdYUbE06j/2E3ekhRSA2kiinYvCdtfjvHJuBLRyEbnftwMjnZVK5exHYrClLZm2 k8CvWhoUF6hOATaQu7WZsL59NYt++uho+hFrygYtBd0fXd4zYHM5IIpEEFC7CuY= =0SNM -----END PGP SIGNATURE----- --------------enig795648CD05CFCA922A2CF770--