From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjrQw-0005AE-Px for qemu-devel@nongnu.org; Sat, 15 Dec 2012 08:05:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjrQv-00053O-IS for qemu-devel@nongnu.org; Sat, 15 Dec 2012 08:05:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjrQv-00053I-Ab for qemu-devel@nongnu.org; Sat, 15 Dec 2012 08:05:37 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBFD5Zdc000992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 15 Dec 2012 08:05:36 -0500 Message-ID: <50CC759E.8040907@redhat.com> Date: Sat, 15 Dec 2012 06:05:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <40005758.24993535.1355562598071.JavaMail.root@redhat.com> In-Reply-To: <40005758.24993535.1355562598071.JavaMail.root@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig44844DE345370A31D081CE6D" Subject: Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44844DE345370A31D081CE6D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/15/2012 02:09 AM, Paolo Bonzini wrote: >>> + /* Allocate a MirrorOp that is used as an AIO callback. */ >>> + op =3D g_slice_new(MirrorOp); >>> + op->s =3D s; >>> + op->iov.iov_base =3D s->buf; >>> + op->iov.iov_len =3D nb_sectors * 512; >> >> Why two spaces? >=20 > To align the equal signs. :) Then I didn't quote enough context. Why the two spaces here, when the very next line didn't align equal signs? >=20 > + op->s =3D s; > + op->iov.iov_base =3D s->buf; > + op->iov.iov_len =3D nb_sectors * 512; > + op->sector_num =3D sector_num; > + op->nb_sectors =3D nb_sectors; --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig44844DE345370A31D081CE6D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQzHWeAAoJEKeha0olJ0NqE1cH+wVP7iItaOpJH/ll4Li9gGX9 SQkA+btz2Tb7RaVhsTKENOiXa/uultzzxTlyCQLp8LB/08uty8B9QNk9YDWOwHyP qT3PClwLGhd/fhsWWORaOrmJtz5n2/xeyM8HBcpob7lNmkdLR1mZiryDWmURwZWe c6qKXquceghR7dYy72JX+Oo8J0s+5VlAZ3mXtO/7H9zZ5cHK4woy0w5+KEWnpMqb 54GULiXwrWcx3ElV1OCUPrGs+ahD8Xp23IqEDVBdk6JpxpF8kBo3pNFXz0QXOdgN lSZG8sX8xLyqIkWCYf05NMw6vptEf9omRvvzLLBZI9n+O66ntR0iUMdZ/qV7Hfk= =wl9O -----END PGP SIGNATURE----- --------------enig44844DE345370A31D081CE6D--