From: "Andreas Färber" <afaerber@suse.de>
To: Julien Grall <julien.grall@gmail.com>
Cc: Julien Grall <julien.grall@citrix.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion
Date: Sat, 15 Dec 2012 18:08:25 +0100 [thread overview]
Message-ID: <50CCAE89.5040102@suse.de> (raw)
In-Reply-To: <CAF3u54Cuede5oGLXHunzs9Qxt_fXLmqXO7EP6E+qbxzfNhMFfg@mail.gmail.com>
Am 15.12.2012 14:45, schrieb Julien Grall:
> On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti <mtosatti@redhat.com> wrote:
>>
>>
>> The high byte of the ioport address is necessary to compute
>> the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)"
>> document, eg:
>>
>> 4.2.1.1. DCOM—DMA Command Register (IO)
>> I/O Address: Channels 0–3—08h; Channels 4–7—0D0h
>>
>
> I sent a patch on the mailing to resolve the problem yesterday
> (http://www.mail-archive.com/qemu-devel@nongnu.org/msg145242.html).
> Did it resolve your WinXp-32 installation? I just need to rework the comment.
>
>>
>> Also the size of the region is wrong.
>
> I don't think the size of the region is wrong. For the second DMA
> controller, the ioports are 0xD0 - 0xDE for the control registers.
> So the size is 16 not 8. It's the same for the channel registers.
You did seem to change it in size, if you compare my review questions,
without you mentioning why in the patch.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-15 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 23:39 [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion Marcelo Tosatti
2012-12-15 9:02 ` Blue Swirl
2012-12-15 13:45 ` Julien Grall
2012-12-15 17:08 ` Andreas Färber [this message]
2012-12-17 0:01 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CCAE89.5040102@suse.de \
--to=afaerber@suse.de \
--cc=julien.grall@citrix.com \
--cc=julien.grall@gmail.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).