From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkVMH-00023c-S0 for qemu-devel@nongnu.org; Mon, 17 Dec 2012 02:47:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkVIo-0001a4-VP for qemu-devel@nongnu.org; Mon, 17 Dec 2012 02:43:29 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:38099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkVIo-0001ZP-8A for qemu-devel@nongnu.org; Mon, 17 Dec 2012 02:39:54 -0500 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Dec 2012 17:33:23 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 5335F2CE804A for ; Mon, 17 Dec 2012 18:39:45 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBH7Sger62718080 for ; Mon, 17 Dec 2012 18:28:42 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBH7diwG012938 for ; Mon, 17 Dec 2012 18:39:44 +1100 Message-ID: <50CECBFA.6090000@linux.vnet.ibm.com> Date: Mon, 17 Dec 2012 15:38:34 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1355725509-5429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1355725509-5429-5-git-send-email-xiawenc@linux.vnet.ibm.com> <24E144B8C0207547AD09C467A8259F75578B461B@lisa.maurer-it.com> In-Reply-To: <24E144B8C0207547AD09C467A8259F75578B461B@lisa.maurer-it.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: "kwolf@redhat.com" , "aliguori@us.ibm.com" , "stefanha@gmail.com" , "qemu-devel@nongnu.org" , "blauwirbel@gmail.com" , "pbonzini@redhat.com" 于 2012-12-17 14:36, Dietmar Maurer 写道: >> This patch is the implemention of transaction based snapshot internal API. > > What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you referring? In group case a check should be done for all snapshot first, and I need to support qmp transaction interface which is already there, so I build an internal transaction layer below to make the interface unified and relative easier to add in qmp transaction. > Seems this makes it impossible to use external commands to make snapshots? > what command? can you tip more about the case? -- Best Regards Wenchao Xia